Re: CVS commit: src/sys

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

tls%rek.tjls.com@localhost wrote:

> On Wed, Mar 25, 2009 at 11:15:16PM +0900, Izumi Tsutsui wrote:
> > tls%rek.tjls.com@localhost wrote:
> > 
> > > What was added to libkern is much simpler than what's in libz (not just
> > > because the libz sources are stylistically gross).  It's not only meant
> > > for use by libz.
> > 
> > Even if so, it should be handled by .PATH.c: in libkern/Makefile.libkern
> > to pull crc32.c, IMO.
> 
> I disagree.  For example, the unmodified crc32.c in libkern does byte
> order checking at runtime, which is just pointless in the kernel.

Hm, then I was confused because the log message said "from zlib to libkern."

> The
> libz source is so dirty, if we have to clean it up at all for in-kernel
> use, better, I think, to just extract the useful part of that file and
> maintain it ourselves.

BTW, can it be shared with userland libz etc?

---
Izumi Tsutsui