Re: CVS commit: src/sys/fs/ptyfs

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Mon, Mar 23, 2009 at 03:00:35AM +0000, YAMAMOTO Takashi wrote:
> > Case 1: You have /dev/pts mounted outside the chroot and want to use
> > e.g. sshd inside the chroot.
> 
> in this case, there is no "correct" pathname anyway, right?
> i think it's more appropriate to return an error so that an application
> can fall back to eg. dev.db.

If the PTSNAME ioctl fails, you don't gain anything. The problem here is
that the old code returned /%d for the chroot in all cases -- making it
impossible to use ptyfs if you also wanted to use e.g. sshd in a chroot.
Without that logic you can null mount /dev/pts and it magically works.

Joerg