Re: CVS commit: src/lib/libc/iconv

[Michael Graff <explorer%flame.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Joerg Sonnenberger wrote:
> On Tue, Mar 03, 2009 at 02:39:07PM +0000, Michael Graff wrote:
>> Log Message:
>> Ignore the magic // commands in iconv_open().  This was discussed on
>> current-users about a month ago, and ignoring the options was the best
>> suggestion.
> 
> Please don't just randomly ignore option arguments. At the very least
> check for *what* options are ignored. While it might be acceptable to
> ignore //ignore, I am already oppossing ignoring //translit. Wildcard
> ignores like this are completely inacceptable though.

- From what I've read, //translit is not guaranteed to work, it's a
best-effort thing.  You can still end up with garbage in your strings,
and therefore cannot rely on the output being safe for, say, filenames.

- --Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmtaJ0ACgkQl6Nz7kJWYWZHOwCfXXuSWGWA6lda34YxosNmQklT
8EkAnjXfYgW9wLSw2EZyMlkYAgCrnCqQ
=7d6b
-----END PGP SIGNATURE-----