Re: p9100 bug?

[Michael <macallan%netbsd.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Feb 28, 2010, at 1:28 PM, der Mouse wrote:

> sys/dev/sbus/p9100.c (1.34) includes a macro PNOZZ_LATCH which is used
> in a handful of places.  However, this is dead code; sc- 
> >sc_last_offset
> is initialized (in various places) to 0xffffffff, and thus will never
> match anything &0xffffff80, so PNOZZ_LATCH will never do anything but
> make that (failing) comparison.

> Is this dead code (and thus removal-worthy), or should the assignment
> to sc_last_offset in PNOZZ_LATCH be outside the if rather than inside?

No, but the == should be an !=.

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBS4tGmspnzkX8Yg2nAQJUQgf9FdkcPVqkBWO2fVNh3NJREEPsIWYRjTIT
CSaovhtKu5b/XO7ghd1rJjU3rNEz/+zw94cXonnQJFyYZjCAajyaNuju2MeXAhH0
rI50X7oXTTsYEVpeGORzlwuGGPHIRXt1z0TQytaARaFHMYXX7PskuqQ2CrKPcNNj
qebYfw32FQCeY/rzEq+W6EHKY/YNbRIxjcxntLkqZPKILvewqfrwHtDdxGBYQqlr
PYiS4aKNb+kVmdqwV8oQFhHqEqgoIBVpnJKMQUvhttopuRVEC3U38dLEeYQLKafG
W2FI5r9UA5MYM9YaZyoVopj1ZghxfyTyydFNr8wDRo3vpYhJ5EviuQ==
=r4d4
-----END PGP SIGNATURE-----