Re: MPC5200 support

[Frank Wille <frank%phoenix.owl.de@localhost>]

Robert Swindells wrote:

> I have put a tarball of new files and diffs on ftp.n.o that add some
> support for the MPC5200 processor on the Efika board.

Wow! Great! A dream comes true!
I will see if I can help debugging in the next weeks. I have three Efikas
waiting for an OS. :)


> So far it boots to single user mode using a PCI Ethernet card and the
> serial console.

I have also seen drivers for ohci, cdm, bestcomm and ata. Do all of them
work?


> A review would be welcome. I haven't debugged the uart driver yet so
> the diffs contain code copied from sys/dev/ofw/ofcons.c, I'm not
> planning on committing this part.

Why was it necessary to include ofcons?


> Testing some of the diffs against macppc to see that I haven't broken
> anything would be helpful too.

I just tried to compile a macppc generic kernel, but it fails because of the
ofcons stuff in ofw_consinit.c:

ofw_consinit.o: In function `ofcons_tty':
ofw_consinit.c:(.text+0x3e): undefined reference to `ofcons_cd'
ofw_consinit.c:(.text+0x42): undefined reference to `ofcons_cd'
ofw_consinit.o: In function `ofcons_poll':
ofw_consinit.c:(.text+0x76): undefined reference to `ofcons_cd'
ofw_consinit.c:(.text+0x7a): undefined reference to `ofcons_cd'
ofw_consinit.o: In function `ofcons_write':
ofw_consinit.c:(.text+0xde): undefined reference to `ofcons_cd'
ofw_consinit.o:ofw_consinit.c:(.text+0xe2): more undefined references to 
`ofcons_cd' follow

*** Failed target:  netbsd


I had the same problem when I compile a GENERIC kernel for ofppc, but I
fixed it with adding "ofcons*" to the config file. This wasn't possible for
macppc, which has its own "macofcons".

Another problem while compiling ofppc/GENERIC occured in
ofppc/ofppc/mainbus.c, which was caused by a missing #ifdef PIC_MPC5200.

Here is my diff for ofppc:

--- ofppc/ofppc/mainbus.c.orig  2009-06-02 23:39:00.000000000 +0200
+++ ofppc/ofppc/mainbus.c   2009-06-02 23:39:32.000000000 +0200
@@ -388,9 +388,11 @@
                isa_cascade = 1;
 #endif
            (void)init_openpic(picnodes[i].node);
+#ifdef PIC_MPC5200
        } else if (picnodes[i].type == PICNODE_TYPE_MPC5200) {
            aprint_debug("calling mpc5200 pic setup\n");
            (void)init_mpc5200pic(picnodes[i].node);
+#endif
        } else
            aprint_error("Unhandled pic node type node=%x\n",
                picnodes[i].node);
--- ofppc/conf/GENERIC.orig 2009-06-03 00:11:21.000000000 +0200
+++ ofppc/conf/GENERIC  2009-06-03 00:13:02.000000000 +0200
@@ -179,6 +179,7 @@
 
 # Generic OpenFirmware console support
 rtas*      at mainbus?
+ofcons*        at mainbus?
 
 # PCI root nodes
 ofwpci*        at mainbus?


I'm looking forward to test your modifications on my Efika tomorrow.
Now I need some sleep... ;)

-- 
    _  Frank Wille (frank%phoenix.owl.de@localhost)
 _ //  http://sun.hasenbraten.de/~frank/
 \X/   Phx @ #AmigaGer