Jason Thorpe wrote:
> There is no need to have the extra layer of indirection. You can
> determine which plb devices are present by simply checking the cpu type
> in the plb driver.
The opinion of `key' members of evbppc port developers
is that there is no problem in the current ibm4xx device structure.
I understood it. I will forget a pseudo mainbus. ;-)
But I don't agree that we will add new declarations (such as (*1)) to
plb and opb driver and update plb.c and opb.c when supporting for new
ibm4xx cpu.
(*1)
const struct opb_dev {
: (snip)
} opb_devs [] = {
/* IBM405GP */
{ IBM405GP, "com", IBM405GP_UART0_BASE, 0, 0 },
{ IBM405GP, "com", IBM405GP_UART1_BASE, 1, 1 },
{ IBM405GP, "emac", IBM405GP_EMAC0_BASE, 0, 9 }, /* XXX: really
irq
9..15 */
{ IBM405GP, "opbgpio", IBM405GP_GPIO0_BASE, 0, -1 },
{ IBM405GP, "gpiic",IBM405GP_IIC0_BASE, 0, 2 },
{ IBM405GP, "wdog", -1, 0, -1 },
: (snip)
};
I want to separate it from plb and opb driver.
I developed a patch (attached with this e-mail).
Are this idea and patch ok?
--
Kind Regards,
--- shige
Shigeyuki Fukushima <shige@{FreeBSD,jp.FreeBSD,NetBSD}.org>
Attachment:
ibm4xx-patch.tar.gz
Description: application/gzip