Re: IBM405GP/GPr OPB bus_space endian (powerpc/ibm4xx/dev/opb.c)

[Shigeyuki Fukushima <shige%netbsd.org@localhost>]

Thanks.

Izumi Tsutsui wrote:
>> -device obsled
>> -attach  obsled at gpio
>> -file        arch/evbppc/obs405/dev/obsled.c         obsled
>> +#device obsled
>> +#attach  obsled at ibmgpio
>> +#file       arch/evbppc/obs405/dev/obsled.c         obsled
> Why is obsled commented out?
> Will it be rewritten to use MI gpio later?
: (snip)
>> -    obs266_led_set(OBS266_LED_ON);
>> +    /* obs266_led_set(OBS266_LED_ON); */
>
> I'm not sure how the leds should be handled by MI gpio,
> but please use #if 0/#endif pair to disable code.

I'll remove it entirely.


>>  # On-chip GPIO controller
>> -device      gpio { addr, [size = -1] }
>> -attach      gpio at opb
>> -file        arch/powerpc/ibm4xx/dev/gpio_opb.c      gpio
>> +device      gpio_opb: gpiobus
>> +attach      gpio_opb at opb
>> +file        arch/powerpc/ibm4xx/dev/gpio_opb.c      gpio_opb
> 
> Underscore in a device name (i.e. "giop_opb0 at opb?" in config files)
> looks weird a bit to me, and I'm afraid it causes some confusion.
> Isn't "opbgpio" like epgpio for arm/ep93xx better?

Other devices on IBM4XX have as same.
We should change IBM4XX device naming rule at the same time.


> Lastly, random KNF stuff:
> - uint32_t rather than u_int32_t
> - no parenthesis around return values
> - "Insert an empty line if the function has no local variables."
> etc.

Ok.

-- 
Kind Regards,
--- shige
Shigeyuki Fukushima <shige@{FreeBSD,jp.FreeBSD,NetBSD}.org>