Port-powerpc archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Repo-copy request: evbppc port for OpenBlockS266



On Tue, Sep 23, 2003 at 01:36:43AM +0900, Shigeyuki Fukushima wrote:
> From: Matt Thomas <matt%3am-software.com@localhost>
> Subject: Re: Repo-copy request: evbppc port for OpenBlockS266
> Date: Sat, 20 Sep 2003 06:57:16 -0700
> 
> Hi, Matt.
> Thank you for your review.
> 
> > sys/arch/openblocks266s is too long of a name.  It would be
> > nice if all the openblocks could share a common port directory
> > (similar in style to evbppc).
> > sys/arch/openblocks would be ok IMO if that was to happen.  If not,
> > maybe ob266s or similar.
> 
> OpenBlockS (first product):    mpc860 cpu
> OpenBlockSS (second product):  ibm405gp cpu
> OpenBlockSR (third product):   ibm405gp cpu
> OpenBlockS266 (forth product): ibm405gpr cpu
> 
> Perhaps we can share a common port directory for 2nd-4th products.
> 'obs405' is suitable for these ports, is it ok?
> 
> New layout:
> 
>    evbppc/conf/OPENBLOCKS266
>    evbppc/conf/files.obs405
>    evbppc/conf/std.obs405
>    evbppc/conf/Makefile.obs405.inc
>    evbppc/obs405/dev/x1226.c
>    evbppc/obs405/dev/x1226reg.h
>    evbppc/obs405/obs405_start.S
>    evbppc/obs405/consinit.c
>    evbppc/obs405/machdep.c
> 
>    powerpc/conf/files.ibm405gp
>    powerpc/ibm4xx/pci/pci_machdep.c
>    powerpc/ibm4xx/pci/pchb.c
>    powerpc/ibm4xx/ibm4xx_machdep.c
>    powerpc/ibm4xx/ibm4xx_autoconf.c
>    powerpc/ibm4xx/dev/iic.c
>    powerpc/ibm4xx/dev/todclock.c
>    powerpc/ibm4xx/dev/iicvar.h
>    powerpc/ibm4xx/dev/todclockvar.h
> 
> 
> consinit.c isn't moved to common directory.
> This is future works. Because com frequecy is different
> between walnut and obs405(OpenBlockS266).
> 
> machdep.c has initppc() function.
> common parts(codes) are included in ibm4xx_machdep.c.

You probably want to separate out the 405-specific parts
from the bits that are common between 401, 403, and 405
cores.  We will also have 440-specific bits at some point,
so I'd think this file should be named ibm40x_machdep.c
to distinguish it from the 440 stuff.

> obs405_start.S is not moved to common directory.
> This is future works too.

Some of the code in the walnut_start.S (which should be
renamed locore.S the way it was originally) and 
walnut/machdep.c is there to import board strapping
information from OpenBIOS.  That should also be factored
out if possible.  BTW, do the OpenBlockS machines use
OpenBIOS or something compatible?

Eduardo



Home | Main Index | Thread Index | Old Index