Hello,
On Wed, 03 Apr 2013 11:03:46 +0400
Phileas Fogg <phileas-fogg%mail.ru@localhost> wrote:
On Tue, 02 Apr 2013 20:59:23 +0200
Phileas Fogg < phileas-fogg%mail.ru@localhost > wrote:
Dumb question, how do we add an indirection to openpic_write and
openpic_read ?
They do not accept any kind of this pointer or context.
Change interface or use global function pointers which can be set in
setup_openpic ?
Here's something that at least works on my iBook G4. The G5's OpenPIC
is found but that's about it ( I was more concerned to keep it working
on 32bit hardware ) - needs more work before it can be committed ( no
fastpath, other openpic variants in pic/ need to be adapted etc. ) but
it adds what's needed to deal with a big endian OpenPIC.
Thanks.
The pic_openpic.c won't work properly on G5.
We need a new PIC module which uses the available OpenPIC framework
but implements extra U3 HT workarounds or add these workarounds to
pic_openpic.c maybe, not sure what is better. I got it working already
but i have to refactor it and make it ready to be commited.
It would be better of course if BE changes were already commited
before i implement it.
Exactly, that's why I posted the patch even though it's unfinished and
poorly tested - to make sure it does what's needed and to avoid
reinventing the wheel.
have fun
Michael