Re: Typo in if_wi_obio.c?

[Michael Lorenz <macallan%netbsd.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Sep 8, 2008, at 5:21 AM, Marco Trillo wrote:

> Hi,
>
> I think there is a typo in src/sys/arch/macppc/dev/if_wi_obio.c, in-
> troduced when the driver was bus-spacified.
>
> In bus_space_map() it hardcodes the address "0x8000000" (six zeros),
> i.e, 0x08000000, instead of 0x80000000 (seven zeros) which is the
> correct base address.
>
> The address was correct in the last revision before bus-spacification.

Good catch, I'll commit the fix later today.

> Maybe it should be using 'ca->ca_baseaddr' to avoid typos when hard-
> coding addresses ?

Absolutely.

have fun
Michael

PS: is there anyone around who actually uses wi at obio? I don't have  
the hardware ( well, I have a G4 with an AirPort slot but no card to  
stick into it ) but when I mess with it I'd like someone to test it  
in order to avoid more muckups like this.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBSMUi28pnzkX8Yg2nAQI6wwf+K7jwtUCAQMYit19aQ5SEtTXAqH3wJ1LF
icGEBvmLXFu+aFDxshDzfrjdYmLQ7JRUB0tNNDIkdKjl6HpMjexUGrKunc2euR7Y
R9NjF4gjMAHe30gTzAMiRBlS9Cu+3O4ZjmnFPjKSgBKLk5BHKaaC1/f8JwinpoAQ
z4xevgvW8clguxU/vOS3FByc9bRh5a7Q0twedz1u90Vn0xi/5C3CCQgRxPq+VN2Z
uxOryrOQX6Pt7rFJZ7nmdLcBsxOnJFjQPqFGwvRdtPwvU2o/cYiudS3eHH/REycc
GT1L+e4/akp3JEUwpGovqQNqTa8Fzx4uoCanJfgNQxPb0xPUNNL8Kw==
=/yjh
-----END PGP SIGNATURE-----