Re: [PATCH] String offset errors on evbarm 8.99 [PR 54159]

[tlaronde%polynum.com@localhost]

On Thu, Aug 15, 2019 at 10:45:10AM +0200, Martin Husemann wrote:
> On Thu, Aug 15, 2019 at 10:27:51AM +0200, tlaronde%polynum.com@localhost wrote:
> > Solution adopted:
> > 	The simplest: since the caller of swap_symbol_in() has the
> > 	information, I added a supplementary parameter to
> > 	swap_symbol_in() to pass the correct symtab_hdr pointer,
> > 	modified the calls and added ATTRIBUTE_UNUSED in the
> > 	implementations that don't use it.
> 
> Great job!
> 
> This should be discussed upstream on the binutils mailing list.
> There is nothing NetBSD specific in here, isn't it?
> 

No. But since it has been done in a NetBSD context, it should be, IMHO,
(after "internal" review; I knew strictly nothing about the whole
binutils stuff before tackling the task) be submitted as a NetBSD
contribution.

Best regards,
-- 
        Thierry Laronde <tlaronde +AT+ polynum +dot+ com>
                     http://www.kergis.com/
                       http://www.sbfa.fr/
Key fingerprint = 0FF7 E906 FBAF FE95 FD89  250D 52B1 AE95 6006 F40C