Re: [guruplug] mvgbe1 no PHY found

[Dave Mills <dmills%63bit.com@localhost>]

There is a slight bug (typo) in the cf_unit abuse update to cvs for
if_mvgbe.c

Incidentally what is cf_unit abuse? 

The update works fine on the guruplug with the patch below applied however
if there is ever a device released with more than two PHYs it wont work.

Dave Mills

Index: ./sys/dev/marvell/if_mvgbe.c
===================================================================
RCS file: /cvsroot/src/sys/dev/marvell/if_mvgbe.c,v
retrieving revision 1.7
diff -u -r1.7 if_mvgbe.c
--- ./sys/dev/marvell/if_mvgbe.c        6 Mar 2011 17:00:16 -0000       1.7
+++ ./sys/dev/marvell/if_mvgbe.c        7 Mar 2011 00:26:01 -0000
@@ -619,7 +619,6 @@
 mvgbe_attach(device_t parent, device_t self, void *aux)
 {
        struct mvgbe_softc *sc = device_private(self);
-       struct mvgbec_softc *csc = device_private(parent);
        struct marvell_attach_args *mva = aux;
        struct mvgbe_txmap_entry *entry;
        struct ifnet *ifp;
@@ -767,7 +766,7 @@
        ifmedia_init(&sc->sc_mii.mii_media, 0,
            mvgbe_mediachange, mvgbe_mediastatus);
        mii_attach(self, &sc->sc_mii, 0xffffffff,
-           parent == mvgebc0 ? 0 : 1, MII_OFFSET_ANY, 0);
+           parent == mvgbec0 ? 0 : 1, MII_OFFSET_ANY, 0);
        if (LIST_FIRST(&sc->sc_mii.mii_phys) == NULL) {
                aprint_error_dev(self, "no PHY found!\n");
                ifmedia_add(&sc->sc_mii.mii_media,

-- 
View this message in context: 
http://old.nabble.com/-guruplug--mvgbe1-no-PHY-found-tp30876058p31084012.html
Sent from the port-arm mailing list archive at Nabble.com.