Re: marvell final patch

[KIYOHARA Takashi <kiyohara%kk.iij4u.or.jp@localhost>]

Hi! Lwazi,


From: Lwazi Dub <lwazidub%gmail.com@localhost>
Date: Tue, 28 Sep 2010 00:03:23 -0400

> It hangs forever when I make the change:

> gttwsi0: unexpected status 0x38: expect 0x28
> strtc0: strtc_clock_read: failed to reset HT
> ^^^--- This is the last line I see

Can you try once again?
m41st84 has Halt Update(HT) bit.  m41t80 not has it.
Please comment out for the time being.  ;-)

Index: m41st84.c
===================================================================
RCS file: /cvsroot/src/sys/dev/i2c/m41st84.c,v
retrieving revision 1.15
diff -u -r1.15 m41st84.c
--- m41st84.c   12 Dec 2009 14:44:10 -0000      1.15
+++ m41st84.c   28 Sep 2010 05:32:19 -0000
@@ -274,6 +274,7 @@
                return (0);
        }
 
+#if have_ht
        /*
         * Check for the HT bit -- if set, then clock lost power & stopped
         * If that happened, then clear the bit so that the clock will have
@@ -297,6 +298,7 @@
                        return (0);
                }
        }
+#endif
 
        /* Read each RTC register in order. */
        for (i = M41ST84_REG_CSEC; i < M41ST84_REG_DATE_BYTES; i++) {
@@ -368,6 +370,7 @@
                return (0);
        }
 
+#if have_ht
        /*
         * Check for the HT bit -- if set, then clock lost power & stopped
         * If that happened, then clear the bit so that the clock will have
@@ -391,6 +394,7 @@
                        return (0);
                }
        }
+#endif
 
        /*
         * Write registers in reverse order. The last write (to the Seconds

Thanks,
--
kiyohara