Port-amiga archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: cardbus in GENERIC



Hi,

On Thu, Sep 26, 2002 at 12:22:28AM +0200, Klaus Heinz wrote:

>  [ need of busspace.*_4 ]
> 
> > Up to know, we never needed this, as we never had anything with 32bit
> > registers in a busified driver.
> 
> Hmm, maybe those 32 bits made me think about cardbus...PCMCIA can only
> handle 16 bits.
> 
> > e.g., PCMCIA can't do this trick, and the ZII devices we're handling 
> > through busXXX() are 8 or 16bit.
> 
> Obviously it was added in v1.41 of dev/ic/smc91cxx.c. Every occurrence
> of the bus_space.*_4 functions is in the 'else' branch of a test for
> the MD flag SMC_FLAGS_32BIT_READ which will hopefully never be set on
> an Amiga.
> 
> Should we add more 'fake 32-bit macros' in amiga/include/bus.h ?

Please not. They should probably be split up into two 16bit accesses in a
meaningful way - for LE busses low order first.

If you add a fake access, it should panic() the machine, at least for 
a kernel with DEBUG set.

Regards,
        -is

Attachment: pgpmjeJQgB371.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index