pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Please review wip/bwa

On Wed, 16 Sep 2015 09:36:38 -0500
Jason Bacon <> wrote:

> This is the first in a long series of genomics packages I've developed 
> and plan to submit.

Nice! We do need more people working on scientific software.

> pkglint -e runs clean, but I'm inviting some ruthlessly critical 
> feedback on this one so that future packages will require minimal tampering.

- You need to use REPLACE_PERL (hint: set PKG_DEVELOPER=yes)
- Homepage URL in DESCR is redundant (pkg_info will display HOMEPAGE)
- HOMEPAGE should not have /../
- "USE_LANGUAGES=c" is the default and can be omitted
- I think(?) we recommend using INSTALLATION_DIRS instead of AUTO_MKDIRS

Also, for extra ruthless mode you can try pkglint -Wall.


Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
pkgsrc-wip-review mailing list

Home | Main Index | Thread Index | Old Index