Re: Please review wip/bwa

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Wed, 16 Sep 2015 09:36:38 -0500
Jason Bacon <jwbacon%tds.net@localhost> wrote:

> This is the first in a long series of genomics packages I've developed 
> and plan to submit.

Nice! We do need more people working on scientific software.

> pkglint -e runs clean, but I'm inviting some ruthlessly critical 
> feedback on this one so that future packages will require minimal tampering.

- You need to use REPLACE_PERL (hint: set PKG_DEVELOPER=yes)
- Homepage URL in DESCR is redundant (pkg_info will display HOMEPAGE)
- HOMEPAGE should not have /../
- "USE_LANGUAGES=c" is the default and can be omitted
- I think(?) we recommend using INSTALLATION_DIRS instead of AUTO_MKDIRS

Also, for extra ruthless mode you can try pkglint -Wall.

-Tobias

------------------------------------------------------------------------------
Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review