Re: wip/munge

[Aleksej Saushev <asau%inbox.ru@localhost>]

Thomas Klausner <thomasklausner%users.sourceforge.net@localhost> writes:

> On Wed, Apr 30, 2014 at 11:10:50AM +0400, Aleksej Saushev wrote:
>> > ERROR: patches/patch-src_etc_Makefile.in:3: Comment expected.
>> 
>> Are we requiring comments to trivial patches?
>
> Yes.
>
>> Why and what for? It is as much useful as "increase variable by 1".
>
> To make live easier for other people updating packages, or for
> yourself after you've forgotten what you've done months or years ago.

There's VCS for that. CVS has code annotation even to help with this.

> A one line comment saves reading a 40-line patch.

It has never happened to me. Instead I have seen multiple occasions
when the comment in patch said "<some OS> support" and what was left was
the code that couldn't even possibly work at all due to invalid C syntax.
So, you still have to read those 40 lines of patch.

As for me, even five hunks each changing one and the same variable or
code pattern say more than overly concise and thus non-descriptive comment.
Sure, you can make comment longer, but then it becomes comparable with
the code itself, the latter being more descriptive.


-- 
HE CE3OH...

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review