Thomas Klausner <thomasklausner%users.sourceforge.net@localhost> writes: > On Wed, Apr 30, 2014 at 11:10:50AM +0400, Aleksej Saushev wrote: >> > ERROR: patches/patch-src_etc_Makefile.in:3: Comment expected. >> >> Are we requiring comments to trivial patches? > > Yes. > >> Why and what for? It is as much useful as "increase variable by 1". > > To make live easier for other people updating packages, or for > yourself after you've forgotten what you've done months or years ago. > A one line comment saves reading a 40-line patch. Also, the comment should explain if the bug has been filed upstream (with a reference to the upstream tracker), or why it's not appropriate to do so. A persistent problem in pkgsrc has been accumulating patches that don't get sent upstream.
Attachment:
pgpNmPK1cwkOI.pgp
Description: PGP signature
------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available. Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs
_______________________________________________ pkgsrc-wip-review mailing list pkgsrc-wip-review%lists.sourceforge.net@localhost https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review