Re: Please review wip/mypaint

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

Hi,

From: "OBATA Akio" <obache%users.sourceforge.net@localhost>, Date: Sun, 19 Dec 
2010 16:19:11 +0900

>> Please review again.
> 
> No need both USE_TOOLS and DEPENDS for bash.
> 
> Using pkg-config and msgfmt tools to build, and you should invoke
> scons with
> ${SETENV} ${MAKE_ENV}.
> 
> Probably, localedir should not be hard-coded in SConstruct as
> share/locale,
> replaced with ${PKGLOCALEDIR}/locale and USE_PKGLOCALEDIR=yes instead.

Thank you for review.

Is USE_PKGLOCALEDIR=yes really needed here?
I do not need replacement mechanism defined
in pkgsrc/mk/configure/replace-localedir.mk.

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3



------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review