Re: Please review wip/mypaint

["OBATA Akio" <obache%users.sourceforge.net@localhost>]

Hi,

On Sun, 19 Dec 2010 13:41:14 +0900, Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost> 
wrote:

> Please review again.

No need both USE_TOOLS and DEPENDS for bash.

Using pkg-config and msgfmt tools to build, and you should invoke scons with
${SETENV} ${MAKE_ENV}.

Probably, localedir should not be hard-coded in SConstruct as share/locale,
replaced with ${PKGLOCALEDIR}/locale and USE_PKGLOCALEDIR=yes instead.

-- 
OBATA Akio / obache%users.sourceforge.net@localhost

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review