Re: Imported wip/libmicro - Review

[Iain Hibbert <plunky%rya-online.net@localhost>]

On Tue, 17 Nov 2009, Jean-Yves Migeon wrote:

>
> On Tue, 17 Nov 2009 16:46:37 +0300, Aleksej Saushev <asau%inbox.ru@localhost> 
> wrote:
> > Jean-Yves Migeon <jeanyves.migeon%free.fr@localhost> writes:
> >
> >> On Tue, 17 Nov 2009 13:03:21 +0100, Thomas Klausner
> >> <thomasklausner%users.sourceforge.net@localhost> wrote:
> >>> On Sun, Nov 15, 2009 at 09:59:09PM +0100, Jean-Yves Migeon wrote:
> >>>> I just imported libmicro into WIP, and would like you to review it.
> >>>
> >>> Doesn't package with USE_DESTDIR=yes on 5.99.22/amd64:
> >>
> >> Alright, same player, shoot again -
> >>
> >> Would it be acceptable to add a variable like ${HARDWARE_ARCH} that
> >> expands
> >> to `uname -m` (or equivalent, depending on the supported OS) in pkgsrc?
> >>
> >> I am not quite certain that having such things in the Makefile:
> >>
> >> INSTALLATION_DIRS+= libexec/libmicro/bin-`uname -m`
> >>
> >> will work as expected, and providing a PLIST for each MACHINE_ARCH seems
> >> overkill to me.

you could provide a LIBMICRO_BINDIR as a PLIST substitution var, that way
the PLIST contains ${LIBMICRO_BINDIR}/blah and is automatically adjusted
for this.

iain



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review