Re: wip/gmp-ecm - reviews wanted

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Sat, 2 Feb 2008 13:55:35 +0100 (CET)
"Christian Sturm" <athaba%inode.at@localhost> wrote:

> Hi,
> 
> this is my first real package (my last/first was p5-Net-SMTP-TLS).
> It's nothing big, so I hope there are not too much errors in it.
> 
> You can find more information regarding ECM on wikipedia:
> http://en.wikipedia.org/wiki/Lenstra_elliptic_curve_factorization
> 
> There are some distributed computing projects about primes and
> factorization using this (and other) software. If I get positive reviews
> I'll maybe add ECMnet. This would add the ability to automatically ask for
> and distribute assignments making distributed computing easier.
> 
> Oh, I'm not sure when to add USE_LANGUAGES and LICENSE to the Makefile.
> Should I add them?
> 
> Sorry for my bad English and please review!

Hi,

Something that you might want to consider adding is
PKG_DESTDIR_SUPPORT=user-destdir.
You can then test this with make clean; make USE_DESTDIR=full package.
It essentially allows packaging software without actually installing it
to the system.
Also, please make sure to use hard tabs when indenting in wip/Makefile,
or you'll break my crude shellscript that parses it. Thanks :-)

Kind regards,
-Tobias

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review