Thanks for taking the time to look at this - your feedback is
invaluable. I've redone a few things in the packages both to address
the issues you brought up, and some brought up by Jared McNeill in a
private email.
I've updated asterisk to version 1.0.7, which fixes a few crashes in the
software, and I also went through and patched over many places where
Makefiles were depending on the existence of header files to turn
features on or off - the features which get enabled are now enabled
explicitly via PKG_OPTIONS. (there are some which are simply disabled -
I just don't have the facility to test them at the present time)
Other points are addressed inline below.
Thomas Klausner wrote:
>On Wed, Mar 16, 2005 at 02:03:49PM -0800, Jeff Rizzo wrote:
>
>
>>I'd appreciate it if anyone with even a passing interest in the Asterisk
>>software PBX on NetBSD to please look at this package (and
>>zaptel-netbsd) and give me your feedback. I'd like to get this polished
>>and moved over to pkgsrc proper sometime after the freeze is over...
>>
>>
>
>pkglint is happy.
>
>CATEGORIES does not contain a proper category (for the import).
>
>
I'm waiting on some input from folks on tech-pkg regarding the best
category here - I'll put zaptel-netbsd in the same one. (probably "net")
>TODO contains one remaining item:
>- add option for graphic console support. Haven't looked at this yet, not
> sure how necessary it is.
>
>
Fixed. (added "gtk" PKG_OPTION)
>options.mk:
>Perhaps you should use PLIST_SUBST for zaptel instead,
>then you could use the default PLIST_SRC handling.
>
>
I did exactly this. Thanks for the suggestion, it's much cleaner,
especially with more options supported.
>First chunk of patch-aa looks wrong.
>
>
Removed. (all that stuff was patched with SUBST_SED anyway)
>patch-ab: should the pbx_gtkconsole be made an option?
>(hm, seems to be the TODO item :) ).
>
>
Option added, and TODO removed.
>Builds, installs, and deinstalls cleanly on 2.0/i386.
>
>zaptel-netbsd:
>
>pkglint is happy.
>
>CATEGORIES has same problem as asterisk.
>
>
(see above)
>Builds and installs cleanly.
>
>Leaves etc/zaptel.conf on deinstall -- why is it not removed automatically?
>[I didn't change it.]
>
>
This was a problem in the distribution (which I maintain) - I fixed it,
and updated the package to use it.
>Leaves lkm on deinstall -- should be removed with
>@unexec ${RMDIR} %D/lkm 2>/dev/null || ${TRUE}
>
>
Fixed, thanks.
>newt:
>
>pkglint is happy.
>
>DISTFILE: is there no real source release, only the redhat rpm?
>
>
No, only the rpm. :(
>WRKDIR=${WRKSRC}/${PKGNAME_NOREV} is perhaps better for updates.
>
>
Ah HAH! I looked for something like that, but didn't see it. Thanks!
:) (fixed)
>do-extract: prefix rpm2pkg with its path, like ${LOCALBASE}/bin/rpm2pkg.
>
>
Fixed.
>do-install: the whiptail installation looks wrong. It should be installed
>by libtool, like the library.
>
>
Fixed per your suggestion below.
>TODO has two entries:
>- Add Python and TCL support options
>- deal a bit better with libtool - shouldn't have to install whiptail from
> ${WRKSRC}/.libs
>
>Ah yes, that's just what I said :)
>
>Shouldn't
>${LIBTOOL} --mode=install ${INSTALL} whiptail ${PREFIX}/bin
>in the right directory work?
>
>How about the tcl and python options?
>
>
I'm not sure how to handle this one - I've looked into it some more, and
I'm not sure I'm up to the task (at least at the moment) - the python
handling looks kind of hairy, and I'm not sure how to begin, frankly.
How important do you think it is that this functionality be included?
>Builds, installs, and deinstalls cleanly.
>
> Thomas
>
>
Thanks again for your look at this.
+j
Attachment:
signature.asc
Description: OpenPGP digital signature