pkgsrc-WIP-review archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
please review wip/traceroute-nanog
- To: pkgsrc-wip-review%lists.sourceforge.net@localhost
- Subject: please review wip/traceroute-nanog
- From: georg.schwarz%freenet.de@localhost (Georg Schwarz)
- Date: Sun, 27 Mar 2005 23:29:58 +0200 See http://spamassassin.org/tag/ for more details. Report problems to http://sf.net/tracker/?func=add&group_id=1&atid=200001 1.0 FORGED_RCVD_HELO Received: contains a forged HELO 0.0 SF_CHICKENPOX_PERIOD BODY: Text interparsed with . 0.0 SF_CHICKENPOX_SLASH BODY: Text interparsed with / 0.0 SF_CHICKENPOX_MINUS BODY: Text interparsed with - 0.0 SF_CHICKENPOX_UNDERSCORE BODY: Text interparsed with _ 0.0 SF_CHICKENPOX_EQUAL BODY: Text interparsed with = 0.0 SF_CHICKENPOX_AT BODY: Text interparsed with @ -0.4 AWL AWL: From: address is in the auto white-list
I would like to ask you to review my newly-added package
wip/traceroute-nanog.
Please have a critical look at the Makefile.
The following questions are of particular concern to me:
- does it compile on your platform? (positive feedback would be welcome
as well :-)). Is the use of the various flags and options correct for
your platform?
- is the order of the items in Makefile correct? pkglint seems to
disagree about certain aspects. I would be happy go receive corrections.
- Should I rather have an extra make target for traceroute-nanog (the
binary) in Makefile? If so, I would welcome suggestions for the Makefile
syntax.
- any suggestions for a HOMEPAGE? Just leave it out?
- Should or should I not make traceroute-nanog suid by default?
anything else I did not even think of is also appreciated of course :-)
Georg
--
Georg Schwarz http://home.pages.de/~schwarz/
georg.schwarz%freenet.de@localhost +49 178 8545053
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review
Home |
Main Index |
Thread Index |
Old Index