pkgsrc-WIP-review archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Please review icecc



On Thu, 10 Mar 2005, Peter Bex wrote:

On Thu, Mar 10, 2005 at 04:34:27PM +0100, Lubomir Sedlacik wrote:
i don't understand the "although any text editor is Ok" part, then.

If any editor is ok, it's probably not right to make it depend on vim
in the first place.
Maybe the package's maintainer can shed some light on this?

Ok, the package is basically a preferences editor for IceWM, with various visual tools for different parts of the configuration. The author thinks though, that the Preferences file its not really worth writing a separate utility for since its quite clear what all the options do and they are easy to find and all grouped together in any case, so any text editor will
work ok for that (I could patch the package to work with vi for instance)

The author uses Vim though, which is a souped up vi editor that can do syntax highlighting, and he wrote config files for vim to tell it how to pick out the juicy bits and put them in the right colours (for IceWM config files), and also a couple of utilities to help the user pick colour numbers since thats not so easy to manage. This part of the package, which he called icewm4vim is the archive that I was having trouble integrating.

Vim itself can be compiled with different front ends and they are marked in the Makefiles as conflicting, so if I depend on plain vim and the host already has vim-gtk2 installed then there will be trouble. Further to this, we have the version number subdirectory for vim config files that I mentioned earlier.

Actually I just had an idea (two even):

Firstly, the maintainer of vim is listed in the Makefile as a real person (instead of tech-pkg%netbsd.org@localhost) so I should email him and see if maybe we
can update vim Makefiles so that I can get the version number out of it.

Secondly, I could make a variable ICECC_EDITOR in the icecc package default to vi (since that is included on most systems I would think) and patch the files accordingly. Also have a MESSAGE to the effect that if you change it to "vim" then you will get extra vim config files and have some funky Makefile logic to install them (or maybe just installed in an examples directory anyway). There would still have to be some user interaction here though, since the users vim config file would need to be changed slightly to map the colour selection utility to a keypress.

unfortunately the editor program name is hardwired into the program so everybody on a single host must use the same preferences file editor.. :)

iain


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review



Home | Main Index | Thread Index | Old Index