Hi,
I won't comment on the package itself, since I don't use IceWM. Sorry :/
> The only bit I dont like, is the preferences editor part, which suggests
> using the Vim editor (although any text editor is Ok) and I've included a
> MESSAGE to point to the parts that would need installing if you wanted to
> use that instead of depending on vim in the package.
IMHO that's not a nice thing to do. Since there seems to be a special
program in your package that uses vim (?), you might want to make building
vim optional, by use of mk/bsd.options.mk. You can of course use a variable
in /etc/mk.conf indicating which vim to build, exactly.
> I cant see a useful way to have a dependency on Vim, since it comes in
> various flavours (vim, vim-gtk2, vim-kde, vim-motif, etc..) and they are
> mutually exclusive. I did think about depending on vim-share, but it does
> a strange thing with its files, puts them in /usr/pkg/share/vim/vim63
> where 63 is version 6.3, which I can't actually get hold of.
>
> Anybody got a better idea than just installing the Vim config files and
> leaving a MESSAGE for the user?
See my above suggestion. Otherwise, you could do many nasty things to find
out which vim is currently installed and end up with a mk/vim.mk, like we
currently have an mk/emacs.mk. That's perhaps the cleanest way to do it if
more packages have this requirement.
Maybe this system could be generalised somehow, for all packages to use,
instead of making exceptions for every package that comes in more than one
flavor. Any good ideas on how to accomplish this?
Regards,
Peter
--
http://www.student.kun.nl/peter.bex
--
"The process of preparing programs for a digital computer
is especially attractive, not only because it can be economically
and scientifically rewarding, but also because it can be an aesthetic
experience much like composing poetry or music."
-- Donald Knuth
Attachment:
pgpONmXAPQxhN.pgp
Description: PGP signature