On Thu, Mar 03, 2005 at 09:46:46AM -0600, Min Sik Kim wrote:
> Thank you for packaging this. I have a few suggestions.
>
> 1. It doesn't build on Darwin, because wnutil.c includes malloc.h. The
> standard place for malloc prototype is stdlib.h.
Absolutely right. I just overlooked this, I guess.
> 2. Tcl/Tk prefix should be ${BUILDLINK_PREFIX.tcl} and
> ${BUILDLINK_PREFIX.tk}, not ${PREFIX}, which is incorrect in the
> pkgviews world.
This is new to me. I should probably read up on this.
> 3. Do not override CC, CFLAGS, LDFLAGS etc. set by pkgsrc. Append
> using "+=" if needed.
Right. I just went in and obliterated most variable passing. What a mess
that was!
> 4. Include buildlink3.mk files before defining the pre-build target.
> See pkgsrc/doc/Makefile-example for more information.
Why is this important? I *think* I've seen more pkgs do it this way...
Well, thanks a lot for your suggestions! You could try if it works on
Darwin now.
Regards,
Peter
--
http://www.student.kun.nl/peter.bex
--
"The process of preparing programs for a digital computer
is especially attractive, not only because it can be economically
and scientifically rewarding, but also because it can be an aesthetic
experience much like composing poetry or music."
-- Donald Knuth
Attachment:
pgp3D2Q2PigXk.pgp
Description: PGP signature