Re: Please review wip/CRWInfo

[Douglas Brebner <kirtai%users.sourceforge.net@localhost>]

On Fri, 14 Jan 2005 10:20:35 +0100
"Julio M. Merino Vidal" <jmmv84%gmail.com@localhost> wrote:

> On Fri, 2005-01-14 at 00:29 +0000, Douglas Brebner wrote:
> > Hi,
> > 
> > This tool extracts information from the raw CRW files produced by
> > Canons digital cameras.
> 
> The package looks quite good.  However, some minor nits:
> 
> 1) Set INSTALLATION_DIRS=bin in the Makefile, just before the
> do-install
>    target.  This will make it more pkgviews friendly.
> 2) It looks like the program does not have a configure script, right?
>    If so, set NO_CONFIGURE=YES in the third paragraph of the Makefile
>    (alphabetic order, please).
> 3) The patch-aa looks wrong.  Without having tried it, I think the
>    second and third lines of the message will appear incorrectly
>    aligned.  So, instead of using \ to escape the newline character,
>    quote all the strings.  That is, you'd end up with something like:
>       printf("-t    this option does\n"
>              "      blah blah...\n"
>              "      blah\n");

Hi, 

I've applied these fixes.

> If you fix these, I'll import your package ;)

Thanks :)

-- 
Douglas


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review