Re: wip/goattracker

[Robert Doerfler <rocrash%gmx.de@localhost>]

> It looks like you generated patch-aa manually. For consistency it's
> recommended to generate patches with pkgdiff(1).

Hmm, i'll used diff -up until now.

 
> Some comments about the patch itself: 
> - Those SUFFIX changes look unneccesary? 
> - avoid hardcoding -I/usr/pkg/include (Use > ${PREFIX}/include) 
> - Append custom CFLAGS in the pkgsrc Makefile instead
>   and make sure it's passed down to the build.

Ok, i will fix it this Weekend, thanks for advice.


-- 
Greetings,
 
  Robert 
 
If you live in a country run by committee, be on the committee.
                -- Graham Summer


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
pkgsrc-wip-discuss mailing list
pkgsrc-wip-discuss%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-discuss