Re: wip/goattracker

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Fri, 9 Oct 2009 13:04:13 +0000 (UTC)
Robert Doerfler <rocrash%gmx.de@localhost> wrote:

> i've commited a package for the latest version (2.68) of the C-64 cross 
> music Editor named "goattracker". I've tested it on NetBSD-5.0.1/i386 so 
> far, linux to come.  As i'm new to pkgsrc development and as this was my 
> first commit any comments would be welcome.  

It looks like you generated patch-aa manually. For consistency it's
recommended to generate patches with pkgdiff(1).

Some comments about the patch itself:
- Those SUFFIX changes look unneccesary?
- avoid hardcoding -I/usr/pkg/include (Use ${PREFIX}/include)
- Append custom CFLAGS in the pkgsrc Makefile instead and make sure it's
  passed down to the build.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
pkgsrc-wip-discuss mailing list
pkgsrc-wip-discuss%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-discuss