Re: CVS commit: wip/jalbum

[Thomas Klausner <thomasklausner%users.sourceforge.net@localhost>]

On Mon, May 02, 2005 at 12:40:56PM +0300, Martti Kuparinen wrote:
> Could you guys try this and let me know if there are any problems
> with the latest version. If everything is okay I'll import it
> to pkgsrc...

DIST_SUBDIR should be PKGNAME_NOREV, so that it doesn't change when
someone bumps a PKGREVISION.

USE_JAVA defaults to yes when you include java-vm.mk, so you
shouldn't need that.

In the do-install target: avoid the tar construct using -C, that
assumes GNU tar. You could e.g. use ${PAX} like this:
        cd ${WRKSRC} && ${PAX} -rw JAlbum ${PREFIX} pax is in the
bootstrap kit.

It's not good pkgsrc style to have a separate subdir for a package
directly under ${PREFIX}, but I guess too much codes assumes the
paths?

Other than that, the package looks good. Oh, review requests
should go to pkgsrc-wip-review instead of -discuss :)

Cheers,
 Thomas


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.  
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
_______________________________________________
pkgsrc-wip-discuss mailing list
pkgsrc-wip-discuss%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-discuss