ncspot: actually needs wide ncurses

[Tobias Nygren <tnn%NetBSD.org@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Tobias Nygren <tnn%NetBSD.org@localhost>
Pushed By:	tnn
Date:		Fri Aug 14 11:19:50 2020 +0200
Changeset:	a6fb8c4cba7d2f6978dc78142e5b44a30f1f68b5

Modified Files:
	ncspot/Makefile
	ncspot/PLIST
Removed Files:
	ncspot/TODO

Log Message:
ncspot: actually needs wide ncurses

the mysterious -l__nonexistent__ error cited in TODO comes from a
BUILDLINK_TRANSFORM in ncurses's bl3.mk file used to catch users
who try to link with the wrong ncurses library.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=a6fb8c4cba7d2f6978dc78142e5b44a30f1f68b5

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 ncspot/Makefile |  2 +-
 ncspot/PLIST    |  4 +---
 ncspot/TODO     | 68 ---------------------------------------------------------
 3 files changed, 2 insertions(+), 72 deletions(-)

diffs:
diff --git a/ncspot/Makefile b/ncspot/Makefile
index e5ea54c26f..d02192928b 100644
--- a/ncspot/Makefile
+++ b/ncspot/Makefile
@@ -421,7 +421,7 @@ do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/target/release/ncspot ${DESTDIR}${PREFIX}/bin
 
 .include "../../security/openssl/buildlink3.mk"
-.include "../../devel/ncurses/buildlink3.mk"
+.include "../../devel/ncursesw/buildlink3.mk"
 .include "../../x11/libxcb/buildlink3.mk"
 .include "../../audio/portaudio/buildlink3.mk"
 .include "../../lang/rust/cargo.mk"
diff --git a/ncspot/PLIST b/ncspot/PLIST
index 92ba51a2d7..971a32e808 100644
--- a/ncspot/PLIST
+++ b/ncspot/PLIST
@@ -1,4 +1,2 @@
 @comment $NetBSD$
-@comment TODO: to fill this file with the file listing:
-@comment TODO: 1. run "/usr/bin/make package"
-@comment TODO: 2. run "/usr/bin/make print-PLIST"
+bin/ncspot
diff --git a/ncspot/TODO b/ncspot/TODO
deleted file mode 100644
index da18d045e8..0000000000
--- a/ncspot/TODO
+++ /dev/null
@@ -1,68 +0,0 @@
-...
-Compiling librespot-playback v0.1.3
-   Compiling ncspot v0.2.1 (/usr/pkgsrc/wip/ncspot/work/ncspot-0.2.1)
-warning: unused variable: `url`
-  --> src/ui/contextmenu.rs:78:45
-   |
-78 |                 ContextMenuAction::ShareUrl(url) => {
-   |                                             ^^^ help: if this is intentional, prefix it with an underscore: `_url`
-   |
-   = note: `#[warn(unused_variables)]` on by default
-
-warning: unused variable: `url`
-  --> src/ui/contextmenu.rs:55:21
-   |
-55 |         if let Some(url) = item.share_url() {
-   |                     ^^^ help: if this is intentional, prefix it with an underscore: `_url`
-
-warning: unused variable: `url`
-   --> src/ui/listview.rs:364:29
-    |
-364 |                 if let Some(url) = url {
-    |                             ^^^ help: if this is intentional, prefix it with an underscore: `_url`
-
-warning: associated function is never used: `cover_url`
-  --> src/playable.rs:32:12
-   |
-32 |     pub fn cover_url(&self) -> Option<String> {
-   |            ^^^^^^^^^
-   |
-   = note: `#[warn(dead_code)]` on by default
-
-warning: variant is never constructed: `ShareUrl`
-  --> src/ui/contextmenu.rs:22:5
-   |
-22 |     ShareUrl(String),
-   |     ^^^^^^^^^^^^^^^^
-
-    Building [=====================================================> ] 402/403: ncspot(bin)
-
-error: linking with `cc` failed: exit code: 1
-  |
-  = note: "cc" "-Wl,--as-needed" "-m64" "-L" "/usr/pkg/lib/rustlib/x86_64-unknown-netbsd/lib" "/usr/pkgsrc/wip/ncspot/work/ncspot-0.2.1/target/release/deps/ncspot-9c8b84529915e6d3.ncspot.2y2t2gst-cgu.0.rcgu.o" "/usr/pkgsrc/wip/ncspot/work/ncspot-0.2.1/target/release/deps/ncspot-9c8b84529915e6d3.ncspot.2y2t2gst-cgu.1.rcgu.o" "/usr/pkgsrc/wip/ncspot/work/ncspot-0.2.1/target/release/deps/ncspot-9c8b84529915e6d3.ncspot.2y2t2gst-cgu.10.rcgu.o" "/usr/pkgsrc/wip/ncspot/work/ncspot-0.2.1/target/release/deps/ncspot-9c8b84529915e6d3.ncspot.2y2t2gst-cgu.11.rcgu.o"...
-
-...
-
-..."/usr/pkg/lib/rustlib/x86_64-unknown-netbsd/lib/librustc_demangle-bb473372fd5b3ac2.rlib" "/usr/pkg/lib/rustlib/x86_64-unknown-netbsd/lib/libunwind-20997f2dc6c9a5ae.rlib" "/usr/pkg/lib/rustlib/x86_64-unknown-netbsd/lib/libcfg_if-5778b82e4fd67c51.rlib" "/usr/pkg/lib/rustlib/x86_64-unknown-netbsd/lib/liblibc-e7ffa3f78a1dcd0d.rlib" "/usr/pkg/lib/rustlib/x86_64-unknown-netbsd/lib/liballoc-aedb0d878184e494.rlib" "/usr/pkg/lib/rustlib/x86_64-unknown-netbsd/lib/librustc_std_workspace_core-8a5eabf13adb835f.rlib" "/usr/pkg/lib/rustlib/x86_64-unknown-netbsd/lib/libcore-c21c595327da7732.rlib" "-Wl,--end-group" "/usr/pkg/lib/rustlib/x86_64-unknown-netbsd/lib/libcompiler_builtins-0a4ec84685f758ec.rlib" "-Wl,-Bdynamic" "-lssl" "-lcrypto" "-lportaudio" "-lossaudio" "-lm" "-lncursesw" "-lutil" "-lrt" "-lutil" "-lexecinfo" "-lpthread" "-lrt" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread" "-lutil" "-lrt" "-lutil"
-  = note: ld: cannot find -l__nonexistent__
-          ld: /usr/pkgsrc/wip/ncspot/work/ncspot-0.2.1/target/release/deps/libtime-2662a67fc4fe1edd.rlib(time-2662a67fc4fe1edd.time.bxl13tkx-cgu.1.rcgu.o): in function `time::tzset':
-          time.bxl13tkx-cgu.1:(.text._ZN4time5tzset17hbf128d8284f532dcE+0x2): warning: warning: reference to compatibility tzset(); include <time.h> for correct reference
-          ld: /usr/pkgsrc/wip/ncspot/work/ncspot-0.2.1/target/release/deps/libncurses-e7b9ce04a0a1de0a.rlib(ncurses-e7b9ce04a0a1de0a.ncurses.46b4gyeo-cgu.0.rcgu.o): in function `ncurses::setlocale':
-          ncurses.46b4gyeo-cgu.0:(.text._ZN7ncurses9setlocale17hc89196a8de290119E+0x54): warning: warning: reference to compatibility setlocale();include <locale.h> for correct reference
-
-
-error: aborting due to previous error; 5 warnings emitted
-
-error: could not compile `ncspot`.
-
-To learn more, run the command again with --verbose.
-*** Error code 101
-
-Stop.
-make[1]: stopped in /usr/pkgsrc/wip/ncspot
-*** Error code 1
-
-Stop.
-make: stopped in /usr/pkgsrc/wip/ncspot
-
-$