Re: at-spi2-core / _XOPEN_SOURCE

[Patrick Welche <prlw1%welche.eu@localhost>]

On Wed, Sep 24, 2025 at 03:43:18PM +0100, Patrick Welche wrote:
> On -current/amd64, at-spi2-core is failing to build for me (with HAVE_GCC=14):
> 
> ../atspi/atspi-event-listener.c: In function 'should_filter_window_events':
> ../atspi/atspi-event-listener.c:1039:3: error: implicit declaration of function 'timersub' [-Wimplicit-function-declaration]
>  1039 |   timersub (&cur_time, &window_filter_time, &elapsed_time);
> 
> 
> This is because it sets _XOPEN_SOURCE=700 (and _GNU_SOURCE) so
> <sys/featuretest.h> doesn't set _NETBSD_SOURCE, so once atspi includes
> <sys/time.h>, the timersub definition is not available.
> 
> What is the "correct" solution?
> 
> In pkgsrc, define _NETBSD_SOURCE if OS = NetBSD ?

Answering my own message... yes:

CFLAGS.NetBSD+= -D_NETBSD_SOURCE


P