Re: Updating net/deskflow - #include <format> and doxygen issues

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Wed, 17 Sep 2025 14:39:09 +0100
David Brownlee <abs%absd.org@localhost> wrote:

> I noticed that net/deskflow didn't build for me - turns out if doxygen
> is installed it unconditionally tries to build its docs.
> 
> There was an existing "-DBUILD_DOCS=OFF" attempt to disable the docs,
> but should we be trying to build it with these (user, not dev) docs?

I personally like to put doxygen under an off-by-default option
unless it is a development package OR the documentation is of
exceptional quality. If we really want to ship documentation we can
also install the markdown sources. Processing these docs with doxygen adds
very little value as they contain ascii art and I would argue are
intended to be readable as-is in the terminal. Realistically most users
will these days use Google or ChatGPT regardless.

> I looked at updating to the next version, but it now uses '#include
> <format>' which looks to be a c++20 feature... but pkgsrc allows gcc12
> for c++20... which does not include support for <format>
> 
> So, we could
> - Add GCC_REQD=13 to force a version of gcc that supports <format>
> - Patch the package to not need <format> (There is already an
> __APPLE__ path that avoids it)
> - Other?

I suspect this is an oversight from the upstream.
Using an __APPLE__ conditional for this is just wrong.
The best approach would be to open an upstream PR and have this cleaned
up properly. I don't want to force a compiler requirement newer than
what is available in NetBSD-current if it is easily avoidable, which it
seems to if they have fallback code that is just not under the
correct conditional. Maybe we just change the __APPLE__ conditionals to
unconditionally evaluate to true for now? (I didn't look at the code
yet).

Kind regards,
-Tobias