Re: [PATCH] sysutils/lnav: update to 0.12.4

[Marko Kaznovac <kaznovac%gmail.com@localhost>]

Hi,


The lnav 0.12.4 update is committed to the WIP
commit sha: 4e089019a4fbb999b73592139ca0fba3ee029d45

The package builds and works correctly on macOS 15.3.1;
but it fails to build on NetBSD, error is described in TODO file

Can someone take a look?
(until I get the local instances/build toolchains up and running)

Thanks!


All the best,
k


On Sat, Mar 22, 2025 at 12:31 PM Marko Kaznovac <kaznovac%gmail.com@localhost> wrote:
>
> Thanks Thomas :)
>
>
> On Wed, Mar 19, 2025 at 3:24 PM Thomas Klausner <wiz%gatalith.at@localhost> wrote:
> >
> > Hi Marko!
> >
> > On Tue, Mar 18, 2025 at 09:37:58PM +0100, Marko Kaznovac wrote:
> > > I've successfully built the latest released  lnav (https://lnav.org/)
> > > 0.12.4 on macOS.
> >
> > I've tried building it on NetBSD, but it failed with:
> >
> > fs_util.cc: In function 'std::optional<std::filesystem::__cxx11::path> lnav::filesystem::self_path()':
> > fs_util.cc:54:18: error: 'PROC_PIDPATHINFO_MAXSIZE' was not declared in this scope
> >    54 |     char pathbuf[PROC_PIDPATHINFO_MAXSIZE];
> >       |                  ^~~~~~~~~~~~~~~~~~~~~~~~
> > fs_util.cc:56:33: error: 'pathbuf' was not declared in this scope
>
> This seems to be a macOS specific implementation in the upstream code...
>
> NB
> I've managed to get NetBSD arm/aarch64 up and running in the latest
> UTM on Sequoia
> https://github.com/utmapp/UTM/discussions/7069#discussioncomment-12585063
> I've seen you faced the same problem on the github issue,
> see if my solution there works for you.
>
> So I might tackle it when I get some more free time :D
>
>
> > I suggest putting it in wip for now so we can get it fixed on NetBSD
> > before updating pkgsrc.
>
> Will do, thanks.
>
>
> All the best,
> k