Re: [PATCH] sysutils/lnav: update to 0.12.4

[Thomas Klausner <wiz%gatalith.at@localhost>]

Hi Marko!

On Tue, Mar 18, 2025 at 09:37:58PM +0100, Marko Kaznovac wrote:
> I've successfully built the latest released  lnav (https://lnav.org/)
> 0.12.4 on macOS.

I've tried building it on NetBSD, but it failed with:

fs_util.cc: In function 'std::optional<std::filesystem::__cxx11::path> lnav::filesystem::self_path()':
fs_util.cc:54:18: error: 'PROC_PIDPATHINFO_MAXSIZE' was not declared in this scope
   54 |     char pathbuf[PROC_PIDPATHINFO_MAXSIZE];
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~
fs_util.cc:56:33: error: 'pathbuf' was not declared in this scope


> Some remarks/questions, as this is my second update to the pkgsrc:
> - should i remove `FORCE_CXX_STD= gnu++17` from the Makefile?

No, the reasoning still applies - the program still uses alloca().

> - few warnings are emitted during compilation, should I patch them?
>   I guess these are better reported to upstream developer,
>   but few existing patch files address some warnings

Yes, please report these upstream and get them fixed there.

> - I've left `PKGREVISION=1`, but it's not needed until the package is rebuilt?
>   I kinda like nb1 suffix :D

No, this should just be removed on updates.

> Sorry for sending a patch like this, I'm figuring out how to get around.
> As I understand, the update procedure goes like this:
> - create gnats-pr with category:pkg, class:change-request, anything else?
> - copy existing lnav code to wip (I have a working wip account, thanks @wiz)
> - commit, push there
> - ping, notify someone? push a few buttons?

Ping the MAINTAINER, but here it's pkgsrc-users, so it was fine.

I suggest putting it in wip for now so we can get it fixed on NetBSD
before updating pkgsrc.

Thanks,
 Thomas