Re: textproc/tinyxml2 shared vs. static libraries

[Thomas Klausner <wiz%gatalith.at@localhost>]

Hi!

On Thu, Mar 20, 2025 at 02:53:09PM +0100, Anthony Mallet wrote:
> Is it on purpose that textproc/tinyxml2 builds static libraries only?
> This change has been introduced with version 9.0.0 with no motivation
> in the commit message, so it might have been an oversight at that time:
> https://github.com/NetBSD/pkgsrc/commit/5aeb3acb3e55b2bdde5ebea5340b5c63a53a4a22

Upstream changed their default, and I didn't think it mattered much
and tend to follow upstream.

> This is currently preventing me from building a shared module because of the
> infamous libtool error (which btw also hurts me with -lgcc, but that's a
> completly different issue):
> ```
> *** Warning: linker path does not have real file for library -ltinyxml2.
> [bla bla]
> *** Last file checked: /usr/pkg-2024Q4/lib/libtinyxml2.a
> [bla bla]
> *** Therefore, libtool will create a static module
> [bla bla]
> ```
> 
> So, just in case enabling shared libraries is not an issue, here is a
> quick patch. It should probably bump PKGREVISION, but I'm not sure
> about the right way to do so.

Just add
PKGREVISION=	1
in the first section.

> Also, the patch is fixing a minor glitch regarding PKGCONFIG_OVERRIDE
> not looking at the right place for tinyxml2.pc.in, which can be fixed
> independently.

Thanks.

The PLIST in your diff was wrong - it's 11 on my system, not 10, were
you using an older checkout? I changed it to match my system.

I've committed this, and bumped the required version in its
buildlink3.mk file, and bumped all (2) dependencies, since they now
need tinyxml2 installed at runtime.

Cheers,
 Thomas