pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: RELRO_SUPPORTED default value (Re: ERROR: [...] missing RELRO

* On 2021-10-10 at 14:15 BST, Makoto Fujiwara wrote:

Probably wrong, but I'm tempted to add following line.


Completely wrong.  What problem are you trying to solve?

The overview for these variables are:

 * _OPSYS_SUPPORTS_FOO is a system variable saying whether the current
   OPSYS supports FOO.  This is not modified.

* FOO_SUPPORTED is a package variable that indicates whether the package can support the FOO option. The default is set in, generally to "yes", so that packages only need to set the variable to "no" when they cannot support the option. This is why the variable needs to be set prior to inclusion.

* PKGSRC_USE_FOO is a user variable giving the user the option to globally enable or disable the option. The default, depending on suitability as to whether it should default to "yes" or "no", is set in defaults/mk.conf.

If, and only if, all three variable types agree then the option is enabled via _PKGSRC_USE_FOO (note the leading underscore), otherwise it is not.

Therefore as you can see adding FOO_SUPPORTED to mk/ is wrong, it should only ever be set by packages, and is a yes/no option.

Jonathan Perkin  -  Joyent, Inc.  -

Home | Main Index | Thread Index | Old Index