[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: Bump - Non-functional xfreerdp2 on 8.1 STABLE - missing POSIX timer_create?
On 17.11.2020 18:06, nia wrote:
I read the actual code that uses POSIX timers, it hasn't changed at all
in the various release candidates.
If you want to simulate building with POSIX timer support disabled,
you can do the following:
Well but it is known that freerdp2 will not connect without those POSIX
The FreeBSD-related PR you linked to enables Linux epoll emulation for
a specific code path.
Well initially they put another ifdef for FREEBSD, but it was removed by
Funny how they mention they do not want to "whitelist" every OS, but yet
code they left whitelists/ifdefs for Apple :-D
If you want to test if that code path is reached, edit the
"os specific implementation is missing" messages in
I tested ;-)
[19:36:37:151] [7164:29fd6000] [INFO][com.freerdp.gdi] - Local
framebuffer format PIXEL_FORMAT_BGRX32
[19:36:37:151] [7164:29fd6000] [INFO][com.freerdp.gdi] - Remote
framebuffer format PIXEL_FORMAT_RGB16
[19:36:37:203] [7164:29fd6000] [INFO][com.winpr.clipboard] - initialized
POSIX local file subsystem
[INFO][com.freerdp.channels.rdpsnd.client] - [static] Loaded fake
backend for rdpsnd
[19:36:37:228] [7164:29fd6000] [ERROR][com.winpr.synch.timer] -
InitializeWaitableTimer: Line 248 of code, 1st apperance
so we are here:
240 #ifdef HAVE_SYS_TIMERFD_H
241 timer->fd = timerfd_create(CLOCK_MONOTONIC,
243 if (timer->fd <= 0)
244 return -1;
246 #elif defined(__APPLE__)
248 WLog_ERR(TAG, "%s: Line 248 of code, 1st
249 result = -1;
Note that there are two such messages, and both are identical.
It would be useful to know which one is being triggered.
It's possible we need to either:
1) Enable the "__APPLE__" code paths in that file on NetBSD too.
2) Borrow the epoll emulation code.
Based on error above and snippet of the code and the fact that
different OSs were
before whitelisted in libwinpr/synch/synch.h which is not the case now:
29 #include <winpr/synch.h>
79 #ifdef HAVE_SYS_TIMERFD_H
80 #include <stdio.h>
81 #include <unistd.h>
82 #include <fcntl.h>
83 #include <sys/timerfd.h>
101 #ifdef WITH_POSIX_TIMER
102 timer_t tid;
103 struct itimerspec timeout;
Isn't it then just a problem during compile not picking up proper
towards NetBSD implementation of POSIX timer?
But then I can see this in libwinpr/synch/CMakeLists.txt:
I can't test this because I don't have a Windows machine to connect
Trying to find under /usr/pkgsrc/net/freerdp2/work some details from
compile time what was picked - if it will be there of course.
Main Index |
Thread Index |