Re: x11/xterm

[Nikita Gillmann <nikita%n0.is@localhost>]

On 2020-07-16 13:11, Ottavio Caruso wrote:
> On Wed, 15 Jul 2020 at 12:31, voidpin <voidpin%protonmail.com@localhost> wrote:
>> I've asked this on tech-pkg but thought I should also ask here,
>>
>> =====================================================================
>> Hi all,
>>
>> Anything against enabling sixel-graphics support on x11/xterm?
>> Thanks for any feedback.
>>
>> ======================================================================
>> diff -u /usr/pkgsrc/x11/xterm/Makefile xterm/Makefile
>> --- /usr/pkgsrc/x11/xterm/Makefile 2019-11-04 02:01:33.000000000 +0100
>> +++ xterm/Makefile 2020-07-10 11:22:19.000000000 +0200
>> @@ -19,6 +19,7 @@
>> CONFIGURE_ARGS+= --enable-256-color
>> CONFIGURE_ARGS+= --enable-paste64
>> CONFIGURE_ARGS+= --enable-readline-mouse
>> +CONFIGURE_ARGS+= --enable-sixel-graphics
>>
>> CONFIGURE_ARGS.standard= # empty
>> CONFIGURE_ARGS.3d= --with-Xaw3d
> Have you tested it on multiple archs/Oses? Have you considered putting
> this is the options file?
>
options.mk with defaulting to suggested would be a good idea.

I don't see how testing on multiple OS and archs is an requirement for a
small change, if it breaks on one system, report a bug and the package
is adjusted.