Re: firefox fails to build on netbsd-8 amd64

[nia <nia%NetBSD.org@localhost>]

On Mon, Jun 22, 2020 at 06:17:08PM -0400, Greg Troxel wrote:
> nia <nia%NetBSD.org@localhost> writes:
> 
> > On Mon, Jun 22, 2020 at 06:17:27PM +0000, maya%NetBSD.org@localhost wrote:
> >> On Mon, Jun 22, 2020 at 06:16:47PM +0000, maya%NetBSD.org@localhost wrote:
> >> > https://mail-index.netbsd.org/tech-userlevel/2018/09/08/msg011381.html
> >> > Probably this. It's fixed in newer NetBSD.
> >> 
> >> Also graphics/MesaLib/patches/patch-src_compiler_builtin__type__macros.h
> >> is the hack for it.
> >
> > Ah, yeah, thanks for the hint.
> >
> > glsl-optimizer is basically embedding a small part of Mesa, so gdt can
> > apply that same patch to:
> >
> > ./work/firefox-77.0.1/third_party/rust/glslopt/glsl-optimizer/src/compiler/builtin_type_macros.h
> 
> Thanks.   have applid the patch, mkpatches and am building.
> 
> So I guess if this builds and runs, I should commit both the API_DEPENDS
> and the patch?  (Certainly it is easy to back out if it breaks things.)

Yes - please add a comment to the patch marking it as being for NetBSD 8
(possibly with a link to that thread) so future readers know it's a hack
that's no longer needed.