Re: elinks upgrade request

[Mayuresh <mayuresh%acm.org@localhost>]

On Mon, Jun 15, 2020 at 10:26:10AM +0000, nia wrote:
> ERROR: PLIST:3: Only the libiconv package may install lib/charset.alias.
> 
> This file should not be installed.
> 
> You can remove it from ${DESTDIR} in the post-install target.
> Something like:
> 
> post-install:
> 	${RM} -f ${DESTDIR}${PREFIX}/lib/charset.alias

1. Adopted, thanks.

> ERROR: patches/patch-src_util_memory.c:3: Each patch must be documented.
> 
> Basically add an explanation to the patch file, under $NetBSD$.

2. I happen to have borrowed the patch from www/elinks and it lacks the
documentation! It seems it is just adopting the signature of mremap for
NetBSD. I am just writing. Please suggest if it can be worded better:

Use macro to make mremap compatible to NetBSD

Both pkglint errors are addressed and removed from TODO.

3. Only 1 TODO is left. In the following snippet I had to remove set -e as
automake was giving some errors, but those were not seen affecting
anything. Through web searches I gathered those are to be treated as
warnings. Please advise.

pre-configure:
        cd ${WRKSRC}; \
        aclocal; autoheader; automake -a --foreign -i; autoconf

Errors with set -e:

set -e; cd /usr/pkgsrc/wip/felinks/work/felinks-0.13.2;  aclocal;
autoheader; automake -a --foreign -i; autoconf
configure.ac:1325: warning: macro 'AM_GNU_GETTEXT' not found in library
config/m4/iconv.m4:1: warning: ill-formed serial number 'AM2', expecting a
version string with only digits and dots
config/m4/codeset.m4:1: warning: ill-formed serial number 'AM1', expecting
a version string with only digits and dots
configure.ac: error: no proper invocation of AM_INIT_AUTOMAKE was found.
configure.ac: You should verify that configure.ac invokes
AM_INIT_AUTOMAKE,
configure.ac: that aclocal.m4 is present in the top-level directory,
configure.ac: and that aclocal.m4 was recently regenerated (using aclocal)
automake: error: no 'Makefile.am' found for any configure output

Mayuresh