Re: "New" package

[Greg Troxel <gdt%lexort.com@localhost>]

Benny Siegert <bsiegert%gmail.com@localhost> writes:

> On Wed, Jan 1, 2020 at 3:57 PM nia <nia%netbsd.org@localhost> wrote:
>>
>> On Wed, Jan 01, 2020 at 03:34:51PM +0100, Benny Siegert wrote:
>> > I tried converting the build to CMake but it needs to be built out of
>> > tree (i.e. build dir != source dir), and I don't know how to do that
>> > in pkgsrc.
>>
>> Set:
>>
>> CONFIGURE_DIRS= build
>> CMAKE_ARG_PATH= ..
>>
>> in pre-configure:
>>
>> ${MKDIR} ${WRKSRC}/build
>
> Thanks! That should be in the guide :)

It would be even better if there were a single declaration to do that,
and perhaps even if it were default, like.

CMAKE_BUILD_DIR?=	yes

that if disabled doesn't do this (because the packge is broken due to
not supporting out-of-tree builds).

> I pushed a wip/herbstluftwm that uses cmake and is pkglint-clean. Any
> objections to putting it into pkgsrc itself?

If you think it's good enough, that's all it takes.