Re: bzip 2 fails to build on IRIX 6.5

[Mark Kirby <demonicjerseycow%gmail.com@localhost>]

> On 7 Oct 2019, at 20:05, Roland Illig <roland.illig%gmx.de@localhost> wrote:
> 
> I don't understand why you edited the command line so massively. It
> should be enough to only remove the "test -n ... verstring". Did you try
> that also?
> 
> Anyway, fixing something at that point is wrong. When libtool is built,
> it must not include this -set_version option. I would look somewhere
> over there to see how the devel/libtool package decides whether to use
> the native linker or the GNU linker, and what options to set.

I think i have libtool working now.

The configure script was correctly identifying the ld used by gcc but it still produced a libtool script using set_version. The configure script has a —with-gnu-ld flag which when set produces the correct commands in the libtool script.

Adding CONFIGURE_ARGS+= --with-gnu-ld to the Makefile in libtool-base sorts that issue for me.

However make install in bzip2 fails because work/.buildink/bin and .buildlink/lib are empty

doing
cp work/bzip2-1.0.8/.libs/bzip2 .buildlink/bin/. 
cp ./bzip2-1.0.8/.libs/* .buildlink/lib/.
bmake install

results in a correctly installed and working bzip.

This issue seems to appear when a package builds a library that it itself depends on. Archivers/xz is another example with the following error

ERROR: /usr/pkg/bin/xzdec:      relink_command="(cd /build/pkgsrc/archivers/xz/work/xz-5.2.4/src/xzdec; { test -z \"\${LIBRARY_PATH+set}\" || unset LIBRARY_PATH || { LIBRARY_PATH=; export LIBRARY_PATH; }; }; { test -z \"\${COMPILER_PATH+set}\" || unset COMPILER_PATH || { COMPILER_PATH=; export COMPILER_PATH; }; }; { test -z \"\${GCC_EXEC_PREFIX+set}\" || unset GCC_EXEC_PREFIX || { GCC_EXEC_PREFIX=; export GCC_EXEC_PREFIX; }; }; { test -z \"\${LD_RUN_PATH+set}\" || unset LD_RUN_PATH || { LD_RUN_PATH=; export LD_RUN_PATH; }; }; LD_LIBRARYN32_PATH=/usr/lib32:/lib32:/usr/lib32/internal:/usr/nekoware/lib:/usr/nekoware/libexec:/usr/nekoware/lib/firefox-2.0.0.20:/usr/nekoware/lib/seamonkey-1.1.14:/usr/nekoware/lib/gimp/2.0:/usr/freeware/lib32:/usr/java/lib32; export LD_LIBRARYN32_PATH; PATH=/build/pkgsrc/archivers/xz/work/.wrapper/bin:/build/pkgsrc/archivers/xz/work/.buildlink/bin:/build/pkgsrc/archivers/xz/work/.tools/bin:/build/pkgsrc/archivers/xz/work/.gcc/bin:/usr/pkg/bin:/opt/local/bin:/opt/local/sbin:/usr/pkg/bin:/usr/pkg/sbin:/opt/local/gcc-8.2.0/bin:/usr/sbin:/usr/bsd:/sbin:/usr/bin:/bin:/etc:/usr/etc:/usr/bin/X11:/usr/gfx:/usr/java/bin:/usr/java/bin32:/usr/nekoware/bin:/usr/nekoware/sbin:/usr/nekoware/drqueue/bin:/usr/local/bin:/usr/demos/Inventor:/usr/local/blender-2.44-irix-6.5-mips:/lib:/usr/lib:/usr/lib32/cmplrs:/usr/local/games/quake2:/usr/local/games/Quake3:/usr/local/ChangeSysId:/usr/local/RealPlayer8:/usr/local/RealPlayer8:/usr/local/divx:/usr/local/ayam/bin:/usr/pegamento:/usr/adobe/Acrobat4.0/bin:/usr/freeware/bin:/usr/lightwave/Bin:/usr/explorer/bin:.; export PATH; gcc -D_REENTRANT -fvisibility=hidden -Wall -Wextra -Wvla -Wformat=2 -Winit-self -Wmissing-include-dirs -Wstrict-aliasing -Wfloat-equal -Wundef -Wshadow -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wlogical-op -Waggregate-return -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -Wredundant-decls -O2 -I/build/pkgsrc/archivers/xz/work/.buildlink/include -Wl,-R/usr/lib32 -Wl,-R/usr/pkg/lib -o @OUTPUT@ xzdec-xzdec.o xzdec-tuklib_progname.o xzdec-tuklib_exit.o  -L/build/pkgsrc/archivers/xz/work/.buildlink/lib -L/usr/pkg/lib -llzma ../../lib/libgnu.a -lpthread -lrt -Wl,-rpath -Wl,/usr/pkg/lib)"
ERROR: *** The above files still have references to the build directory.
ERROR:     This is possibly an error that should be fixed by unwrapping
ERROR:     the files or adding missing tools to the package makefile!
*** Error code 1

Stop.
bmake[1]: stopped in /mnt/pkgsrc/archivers/xz
*** Error code 1

Stop.
bmake: stopped in /mnt/pkgsrc/archivers/xz

There