Re: time/ical build failure

[Havard Eidnes <he%NetBSD.org@localhost>]

>>> In file included from main.C:27:0:
>>> bitmaps/left.xbm:7:50: error: narrowing conversion of '128' from 'int'
>>> to 'char' inside { } [-Wnarrowing]
>>>     0x20, 0x01, 0x40, 0x01, 0x80, 0x01, 0x00, 0x00};
>>>                                                   ^
>>> bitmaps/left.xbm:7:50: error: narrowing conversion of '128' from 'int'
>>> to 'char' inside { } [-Wnarrowing]
>>> In file included from main.C:28:0:
>>> bitmaps/right.xbm:7:50: error: narrowing conversion of '128' from
>>> 'int' to 'char' inside { } [-Wnarrowing]
>>>     0x80, 0x04, 0x80, 0x02, 0x80, 0x01, 0x00, 0x00};
>>>                                                   ^
>>> bitmaps/right.xbm:7:50: error: narrowing conversion of '128' from
>>> 'int' to 'char' inside { } [-Wnarrowing]
>>> bitmaps/right.xbm:7:50: error: narrowing conversion of '128' from
>>> 'int' to 'char' inside { } [-Wnarrowing]
>>>
>>> <lots more of these!>
>>
>> Hmm, using 8.0_BETA I don't get these warnings, perhaps it's
>> caused by new checks in the new compiler; 8.0_BETA has gcc 5.5.0.
>>
>> And, well, I suspect the correct fix is more widspread use of
>> "unsigned char", since, indeed 0x80 == 128 isn't part of the
>> value range for signed char.  However, that's likely to cause
>> cascading type changes...  Is the packge being built with -Werror?
>
> This is almost certainly due to the update of gcc-6 on amd64-HEAD
>
> This is a totally-default build, on an amd64 host running 8.99.12 from
> just a few days ago.  And there are no error messages other than the
> -Wnarrowing errors.  (But there are dozens of these messages, and they
> are reported in several *.xbm files, not only {left,right}.xbm!)

Could you try the attached diff?  Remember to do "make mps"
before trying to build to update distinfo.  It still builds with
this on 8.0_BETA, at least.

Regards,

- Håvard

--- /dev/null	2018-02-18 23:32:00.312786199 +0100
+++ patches/patch-bitmaps_dleft.xbm	2018-02-18 23:31:46.310238395 +0100
@@ -0,0 +1,12 @@
+$NetBSD$
+
+--- bitmaps/dleft.xbm.orig	2009-01-18 13:18:18.000000000 +0000
++++ bitmaps/dleft.xbm
+@@ -1,6 +1,6 @@
+ #define dleft_width 16
+ #define dleft_height 16
+-static char dleft_bits[] = {
++static unsigned char dleft_bits[] = {
+    0x00, 0x00, 0x80, 0x61, 0xc0, 0x71, 0xe0, 0x79, 0xf0, 0x7d, 0xf8, 0x7f,
+    0xfc, 0x7f, 0xfe, 0x7f, 0xfe, 0x7f, 0xfc, 0x7f, 0xf8, 0x7f, 0xf0, 0x7d,
+    0xe0, 0x79, 0xc0, 0x71, 0x80, 0x61, 0x00, 0x00};
--- /dev/null	2018-02-18 23:32:00.312786199 +0100
+++ patches/patch-bitmaps_done.xbm	2018-02-18 23:31:46.314942874 +0100
@@ -0,0 +1,12 @@
+$NetBSD$
+
+--- bitmaps/done.xbm.orig	2009-01-18 13:18:19.000000000 +0000
++++ bitmaps/done.xbm
+@@ -1,6 +1,6 @@
+ #define done_width 16
+ #define done_height 16
+-static char done_bits[] = {
++static unsigned char done_bits[] = {
+    0x00, 0x00, 0xff, 0x8f, 0xff, 0x67, 0x03, 0x30, 0x03, 0x18, 0x03, 0x4c,
+    0x33, 0x6e, 0x7b, 0x67, 0xff, 0x67, 0xfb, 0x63, 0xf3, 0x63, 0xe3, 0x61,
+    0xc3, 0x61, 0x83, 0x60, 0xff, 0x7f, 0xff, 0x7f};
--- /dev/null	2018-02-18 23:32:00.312786199 +0100
+++ patches/patch-bitmaps_dright.xbm	2018-02-18 23:31:46.319659296 +0100
@@ -0,0 +1,12 @@
+$NetBSD$
+
+--- bitmaps/dright.xbm.orig	2009-01-18 13:18:19.000000000 +0000
++++ bitmaps/dright.xbm
+@@ -1,6 +1,6 @@
+ #define dright_width 16
+ #define dright_height 16
+-static char dright_bits[] = {
++static unsigned char dright_bits[] = {
+    0x00, 0x00, 0x86, 0x01, 0x8e, 0x03, 0x9e, 0x07, 0xbe, 0x0f, 0xfe, 0x1f,
+    0xfe, 0x3f, 0xfe, 0x7f, 0xfe, 0x7f, 0xfe, 0x3f, 0xfe, 0x1f, 0xbe, 0x0f,
+    0x9e, 0x07, 0x8e, 0x03, 0x86, 0x01, 0x00, 0x00};
--- /dev/null	2018-02-18 23:32:00.312786199 +0100
+++ patches/patch-bitmaps_ical.xbm	2018-02-18 23:31:46.324371736 +0100
@@ -0,0 +1,12 @@
+$NetBSD$
+
+--- bitmaps/ical.xbm.orig	2009-01-18 13:18:18.000000000 +0000
++++ bitmaps/ical.xbm
+@@ -1,6 +1,6 @@
+ #define ical_width 64
+ #define ical_height 54
+-static char ical_bits[] = {
++static unsigned char ical_bits[] = {
+    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+    0x00, 0x00, 0x30, 0x00, 0xc0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x68, 0x00,
--- /dev/null	2018-02-18 23:32:00.312786199 +0100
+++ patches/patch-bitmaps_left.xbm	2018-02-18 23:31:46.329065949 +0100
@@ -0,0 +1,13 @@
+$NetBSD$
+
+--- bitmaps/left.xbm.orig	2009-01-18 13:18:19.000000000 +0000
++++ bitmaps/left.xbm
+@@ -1,7 +1,7 @@
+ /* Copyright (c) 1993 by Sanjay Ghemawat */
+ #define left_width 16
+ #define left_height 16
+-static char left_bits[] = {
++static unsigned char left_bits[] = {
+    0x00, 0x00, 0x80, 0x01, 0x40, 0x01, 0x20, 0x01, 0x10, 0x01, 0x08, 0x7f,
+    0x04, 0x40, 0x02, 0x40, 0x02, 0x40, 0x04, 0x40, 0x08, 0x7f, 0x10, 0x01,
+    0x20, 0x01, 0x40, 0x01, 0x80, 0x01, 0x00, 0x00};
--- /dev/null	2018-02-18 23:32:00.312786199 +0100
+++ patches/patch-bitmaps_right.xbm	2018-02-18 23:31:46.333768821 +0100
@@ -0,0 +1,13 @@
+$NetBSD$
+
+--- bitmaps/right.xbm.orig	2009-01-18 13:18:19.000000000 +0000
++++ bitmaps/right.xbm
+@@ -1,7 +1,7 @@
+ /* Copyright (c) 1993 by Sanjay Ghemawat */
+ #define right_width 16
+ #define right_height 16
+-static char right_bits[] = {
++static unsigned char right_bits[] = {
+    0x00, 0x00, 0x80, 0x01, 0x80, 0x02, 0x80, 0x04, 0x80, 0x08, 0xfe, 0x10,
+    0x02, 0x20, 0x02, 0x40, 0x02, 0x40, 0x02, 0x20, 0xfe, 0x10, 0x80, 0x08,
+    0x80, 0x04, 0x80, 0x02, 0x80, 0x01, 0x00, 0x00};
--- /dev/null	2018-02-18 23:32:00.312786199 +0100
+++ patches/patch-bitmaps_sleft.xbm	2018-02-18 23:31:46.338434189 +0100
@@ -0,0 +1,12 @@
+$NetBSD$
+
+--- bitmaps/sleft.xbm.orig	2009-01-18 13:18:18.000000000 +0000
++++ bitmaps/sleft.xbm
+@@ -1,6 +1,6 @@
+ #define sleft_width 16
+ #define sleft_height 16
+-static char sleft_bits[] = {
++static unsigned char sleft_bits[] = {
+    0x00, 0x00, 0x00, 0x0c, 0x00, 0x0e, 0x00, 0x0f, 0x80, 0x0f, 0xc0, 0x0f,
+    0xe0, 0x0f, 0xf0, 0x0f, 0xf0, 0x0f, 0xe0, 0x0f, 0xc0, 0x0f, 0x80, 0x0f,
+    0x00, 0x0f, 0x00, 0x0e, 0x00, 0x0c, 0x00, 0x00};
--- /dev/null	2018-02-18 23:32:00.312786199 +0100
+++ patches/patch-bitmaps_sright.xbm	2018-02-18 23:31:46.343115340 +0100
@@ -0,0 +1,12 @@
+$NetBSD$
+
+--- bitmaps/sright.xbm.orig	2009-01-18 13:18:18.000000000 +0000
++++ bitmaps/sright.xbm
+@@ -1,6 +1,6 @@
+ #define sright_width 16
+ #define sright_height 16
+-static char sright_bits[] = {
++static unsigned char sright_bits[] = {
+    0x00, 0x00, 0x30, 0x00, 0x70, 0x00, 0xf0, 0x00, 0xf0, 0x01, 0xf0, 0x03,
+    0xf0, 0x07, 0xf0, 0x0f, 0xf0, 0x0f, 0xf0, 0x07, 0xf0, 0x03, 0xf0, 0x01,
+    0xf0, 0x00, 0x70, 0x00, 0x30, 0x00, 0x00, 0x00};
--- /dev/null	2018-02-18 23:32:00.312786199 +0100
+++ patches/patch-bitmaps_todo.xbm	2018-02-18 23:31:46.347815559 +0100
@@ -0,0 +1,12 @@
+$NetBSD$
+
+--- bitmaps/todo.xbm.orig	2009-01-18 13:18:18.000000000 +0000
++++ bitmaps/todo.xbm
+@@ -1,6 +1,6 @@
+ #define todo_width 16
+ #define todo_height 16
+-static char todo_bits[] = {
++static unsigned char todo_bits[] = {
+    0x00, 0x00, 0xff, 0x7f, 0xff, 0x7f, 0x03, 0x60, 0x03, 0x60, 0x03, 0x60,
+    0x03, 0x60, 0x03, 0x60, 0x03, 0x60, 0x03, 0x60, 0x03, 0x60, 0x03, 0x60,
+    0x03, 0x60, 0x03, 0x60, 0xff, 0x7f, 0xff, 0x7f};