Re: time/ical build failure

[Havard Eidnes <he%NetBSD.org@localhost>]

> At least at first glance, this one does not appear to be related to
> openssl!
>
> ...
> ical.C: In function 'void trigger(Tcl_Interp*, const char*, const
> char*)':
> ical.C:144:59: warning: 'Tcl_Interp::result' is deprecated: use
> Tcl_GetStringResult/Tcl_SetResult [-Wdeprecated-declarations]
>          fprintf(stderr, "ical: trigger error: %s\n", tcl->result);
>                                                            ^~~~~~
> In file included from ical.h:5:0,
>                  from ical.C:6:
> /tmp/pkgs/time/ical/work.x86_64/.buildlink/include/tcl.h:170:71: note:
> declaredhere
>  # define TCL_DEPRECATED_API(msg) __attribute__ ((__deprecated__ (msg)))
>                                                                        ^
> /tmp/pkgs/time/ical/work.x86_64/.buildlink/include/tcl.h:503:18: note:
> in expansion of macro 'TCL_DEPRECATED_API'
>      char *result TCL_DEPRECATED_API("use
>      Tcl_GetStringResult/Tcl_SetResult");
>                   ^~~~~~~~~~~~~~~~~~
> ical.C:144:59: warning: 'Tcl_Interp::result' is deprecated: use
> Tcl_GetStringResult/Tcl_SetResult [-Wdeprecated-declarations]
>          fprintf(stderr, "ical: trigger error: %s\n", tcl->result);
>                                                            ^~~~~~
> In file included from ical.h:5:0,
>                  from ical.C:6:
> /tmp/pkgs/time/ical/work.x86_64/.buildlink/include/tcl.h:170:71: note:
> declaredhere
>  # define TCL_DEPRECATED_API(msg) __attribute__ ((__deprecated__ (msg)))
>                                                                        ^
> /tmp/pkgs/time/ical/work.x86_64/.buildlink/include/tcl.h:503:18: note:
> in expansion of macro 'TCL_DEPRECATED_API'

Fixed these ones by using the suggested newer API.

> ...
>
> In file included from main.C:27:0:
> bitmaps/left.xbm:7:50: error: narrowing conversion of '128' from 'int'
> to 'char' inside { } [-Wnarrowing]
>     0x20, 0x01, 0x40, 0x01, 0x80, 0x01, 0x00, 0x00};
>                                                   ^
> bitmaps/left.xbm:7:50: error: narrowing conversion of '128' from 'int'
> to 'char' inside { } [-Wnarrowing]
> In file included from main.C:28:0:
> bitmaps/right.xbm:7:50: error: narrowing conversion of '128' from
> 'int' to 'char' inside { } [-Wnarrowing]
>     0x80, 0x04, 0x80, 0x02, 0x80, 0x01, 0x00, 0x00};
>                                                   ^
> bitmaps/right.xbm:7:50: error: narrowing conversion of '128' from
> 'int' to 'char' inside { } [-Wnarrowing]
> bitmaps/right.xbm:7:50: error: narrowing conversion of '128' from
> 'int' to 'char' inside { } [-Wnarrowing]
>
> <lots more of these!>

Hmm, using 8.0_BETA I don't get these warnings, perhaps it's
caused by new checks in the new compiler; 8.0_BETA has gcc 5.5.0.

And, well, I suspect the correct fix is more widspread use of
"unsigned char", since, indeed 0x80 == 128 isn't part of the
value range for signed char.  However, that's likely to cause
cascading type changes...  Is the packge being built with -Werror?

Regards,

- Håvard