Re: upcoming lighttpd 1.4.40 release

[Thomas Klausner <wiz%NetBSD.org@localhost>]

Hi Glenn!

On Tue, Jun 28, 2016 at 11:32:18PM -0400, Glenn Strauss wrote:
> Greetings NetBSD lighttpd pkgsrc maintainers.  I joined the lighttpd
> development team in Feb and we are preparing to release 1.4.40, which
> includes many, many fixes.

Thanks for reaching out to us!

> * Do you have any requests or outstanding NetBSD bugs which can be
>   fixed to make things easier for NetBSD port/pkgsrc maintenance?

We have three patches in pkgsrc (against 1.4.39). One just changes
defaults to match pkgsrc paths & users.

I'll attach the other two.

> * Is there anyone in NetBSD-land who can smoke test lighttpd git HEAD
>   and provide feedback if there is anything amiss with NetBSD support?

I'm not running lighttpd myself, sorry.

> * The lighttpd mailing lists are very quiet.  Are you subscribed?
>   Should I sent future messages there, or do you prefer if I sent
>   email to the port maintainer? (pkgsrc-users@)
>   https://redmine.lighttpd.net/projects/lighttpd/wiki/Mailinglists

pkgsrc-users is fine.

Cheers,
 Thomas

$NetBSD: patch-src_fdevent_poll.c,v 1.1 2014/01/23 13:20:12 adam Exp $

Error fix.

--- src/fdevent_poll.c.orig	2014-01-23 11:58:57.000000000 +0000
+++ src/fdevent_poll.c
@@ -193,7 +193,7 @@ int fdevent_poll_init(fdevents *ev) {
 int fdevent_poll_init(fdevents *ev) {
 	UNUSED(ev);
 
-	log_error_write(srv, __FILE__, __LINE__,
+	log_error_write(ev->srv, __FILE__, __LINE__,
 		"s", "poll is not supported, try to set server.event-handler = \"select\"");
 
 	return -1;

$NetBSD: patch-src_plugin.c,v 1.1 2013/01/11 11:00:02 fhajny Exp $

On SunOS, dlopen() may return non-NULL on success too.
--- src/plugin.c.orig	2010-08-17 09:04:38.000000000 +0000
+++ src/plugin.c
@@ -205,12 +205,14 @@ int plugins_load(server *srv) {
 #else
 		*(void **)(&init) = dlsym(p->lib, srv->tmp_buf->ptr);
 #endif
+#if !defined(__sun)
 		if ((error = dlerror()) != NULL)  {
 			log_error_write(srv, __FILE__, __LINE__, "s", error);
 
 			plugin_free(p);
 			return -1;
 		}
+#endif
 
 #endif
 		if ((*init)(p)) {