pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: gnome 2.32 window borders




On 18/05/16 14:43, Richard PALO wrote:

> Though not your breaker, the following fixes the loop warning...
>> $NetBSD$
>>
>> iterate via enum to avoid 'iteration 2u invokes undefined behavior' warning
>>
>> --- sensors-applet/active-sensor.c.orig	2015-10-06 16:57:49.000000000 +0000
>> +++ sensors-applet/active-sensor.c
>> @@ -439,8 +439,8 @@ ActiveSensor *active_sensor_new(SensorsA
>>  
>>  	active_sensor->sensor_row = sensor_row;
>>  
>> -        int i;
>> -        for (i = 0; i < NUM_NOTIFS; i++) {
>> +        NotifType i;
>> +        for (i = LOW_ALARM; i < NUM_NOTIFS; i++) {
>>                  active_sensor->alarm_timeout_id[i] = -1;
>>          }
> 
> Apparently sensors-applet/Makefile.in hardcodes:
>> mate_sensors_applet_LDADD = -ldl
> but still uses $LIBS in the invocation, so perhaps it is enough to remove the '-ldl' here
> since configure seems to check for the need of '-ldl' in setting LIBS already.
> Worth a try.
> 
I just committed this fix, thank you!

> no idea about your itstool issue, though.
> 
Me neither :-(

> cheers
> 

--
Youri


Home | Main Index | Thread Index | Old Index