Re: gnome 2.32 window borders

[Richard PALO <richard%netbsd.org@localhost>]

Le 18/05/16 11:57, Thomas Klausner a écrit :
> I sometimes see:
> 
> if test -f "${mo}"; then mo="../${mo}"; else mo="/scratch/wip/mate-applets/work/mate-applets-1.14.0/drivemount/help/${mo}"; fi; \
> (cd "oc/" && itstool -m "${mo}" ${d}/C/index.docbook ${d}/C/legal.xml) && \
> touch "oc/oc.stamp"
> Traceback (most recent call last):
>   File "/usr/pkg/bin/itstool", line 1516, in <module>
>     doc.apply_its_rules(not(opts.nobuiltins), params=params)
>   File "/usr/pkg/bin/itstool", line 721, in apply_its_rules
>     for dfile in os.listdir(itsdir):
> OSError: [Errno 13] Permission denied: '/usr/pkg/share/itstool/its'
> Makefile:617: recipe for target 'es/es.stamp' failed
> 
> And then there's this one, which I don't know how you would not meet :)
> 
> ===> Building for mate-sensors-applet-1.14.0
> Making all in sensors-applet
> gmake[1]: Entering directory '/scratch/wip/mate-sensors-applet/work/mate-sensors-applet-1.14.0/sensors-applet'
> /usr/pkg/bin/gmake  all-am
> gmake[2]: Entering directory '/scratch/wip/mate-sensors-applet/work/mate-sensors-applet-1.14.0/sensors-applet'
>   CC       about-dialog.o
>   CC       active-sensor.o
>   CC       prefs-dialog.o
>   CC       sensor-config-dialog.o
>   CC       sensors-applet.o
>   CC       sensors-applet-plugins.o
>   CC       sensors-applet-settings.o
>   CC       main.o
> active-sensor.c: In function 'active_sensor_new':
> active-sensor.c:444:52: warning: iteration 2u invokes undefined behavior [-Waggressive-loop-optimizations]
>                  active_sensor->alarm_timeout_id[i] = -1;
>                                                     ^
> active-sensor.c:443:9: note: containing loop
>          for (i = 0; i < NUM_NOTIFS; i++) {
>          ^
>   CC       active-sensor-libnotify.o
>   CCLD     mate-sensors-applet
> ld: cannot find -ldl
> Makefile:541: recipe for target 'mate-sensors-applet' failed
> gmake[2]: *** [mate-sensors-applet] Error 1
> gmake[2]: Leaving directory '/scratch/wip/mate-sensors-applet/work/mate-sensors-applet-1.14.0/sensors-applet'
> Makefile:442: recipe for target 'all' failed
> gmake[1]: *** [all] Error 2
> gmake[1]: Leaving directory '/scratch/wip/mate-sensors-applet/work/mate-sensors-applet-1.14.0/sensors-applet'
> Makefile:570: recipe for target 'all-recursive' failed
> gmake: *** [all-recursive] Error 1
> *** Error code 2
> 

Though not your breaker, the following fixes the loop warning...
> $NetBSD$
> 
> iterate via enum to avoid 'iteration 2u invokes undefined behavior' warning
> 
> --- sensors-applet/active-sensor.c.orig	2015-10-06 16:57:49.000000000 +0000
> +++ sensors-applet/active-sensor.c
> @@ -439,8 +439,8 @@ ActiveSensor *active_sensor_new(SensorsA
>  
>  	active_sensor->sensor_row = sensor_row;
>  
> -        int i;
> -        for (i = 0; i < NUM_NOTIFS; i++) {
> +        NotifType i;
> +        for (i = LOW_ALARM; i < NUM_NOTIFS; i++) {
>                  active_sensor->alarm_timeout_id[i] = -1;
>          }

Apparently sensors-applet/Makefile.in hardcodes:
> mate_sensors_applet_LDADD = -ldl
but still uses $LIBS in the invocation, so perhaps it is enough to remove the '-ldl' here
since configure seems to check for the need of '-ldl' in setting LIBS already.
Worth a try.

no idea about your itstool issue, though.

cheers
-- 
Richard PALO