pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [patch] pkgtools/autoswc modified for non-default, non-root install

* On 2015-07-01 at 10:53 BST, Andreas Kusalananda Kähäri wrote:

> Index: Makefile
> ===================================================================
> RCS file: /Users/akk/pkg/pkgsrc-cvs/pkgsrc/pkgtools/autoswc/Makefile,v
> retrieving revision 1.21
> diff -r1.21 Makefile
> 3a4
> 18,19c19,20
> < CACHEDIR=		/var/db/autoswc
> < MKCONF=			/etc/mk.conf
> ---
> > CACHEDIR=		${VARBASE}/db/autoswc
> > MKCONF=			${PKG_SYSCONFDIR}/mk.conf

Both these MKCONF settings are wrong, as you either make it work for
native users (/etc/mk.conf) or for bootstrap users
(${PKG_SYSCONFDIR}/mk.conf) but not both.

At this time we do not define the path to the mk.conf that was used,
so the only real solution is to duplicate the logic in to
try MAKECONF then ${PKG_SYSCONFDIR}/mk.conf then mk.conf.

Then again, as it is only used in this package to warn when the user
hasn't enabled the feature in their mk.conf it might be worth just
ripping it out, but I'd leave it to jmmv as the author to have final
say on that.

The CACHEDIR change is good though.


Jonathan Perkin  -  Joyent, Inc.  -

Home | Main Index | Thread Index | Old Index