Re: net/mDNSResponder is broken under NetBSD

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Fri, Feb 25, 2011 at 12:00:29AM +0800, Rui-Xiang Guo wrote:
> Hi, all.
> The error messages as below -
> [...]
> cc dns-sd.c ClientCommon.c -L../mDNSPosix/build/prod/ -ldns_sd -L/usr/lib 
> -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -I../mDNSShared -Wall -o build/dns-sd
> dns-sd.c: In function 'RegisterService':
> dns-sd.c:1010: warning: array subscript has type 'char'
> dns-sd.c:1010: warning: array subscript has type 'char'
> dns-sd.c: In function 'main':
> dns-sd.c:1043: error: 'kFilePathSep' undeclared (first use in this function)
> dns-sd.c:1043: error: (Each undeclared identifier is reported only once
> dns-sd.c:1043: error: for each function it appears in.)
> ClientCommon.c: In function 'GetNextLabel':
> ClientCommon.c:55: warning: array subscript has type 'char'
> ClientCommon.c:55: warning: array subscript has type 'char'
> ClientCommon.c:55: warning: array subscript has type 'char'
> gmake[1]: *** [build/dns-sd] Error 1
> gmake[1]: Leaving directory 
> `/usr/pkgsrc/net/mDNSResponder/work/mDNSResponder-258.14/Clients'
> gmake: *** [../Clients/build/dns-sd] Error 2
> *** Error code 2
> 
> It seems caused by the patch for dns-sd.c -
> [...]
>     172 #ifdef __linux__
>     173         static const char kFilePathSep = '/';
>     174         static size_t _sa_len(const struct sockaddr *addr)
> [...]

I've just committed a fix for this.

> BTW, why the patch name not to follow the patch-xx rule?

Because the convention changed recently, per a discussion last June.

The change was announced on tech-pkg; I probably should have mentioned
here as well, sorry for that.

http://mail-index.netbsd.org/tech-pkg/2011/02/02/msg006659.html

 Thomas